-
Notifications
You must be signed in to change notification settings - Fork 401
upcoming: [UIE-10426] - Add new endpoints, types and Queries for Reserved IPs #13517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4b66e1a
7ba7251
fa1ae83
f439cdd
a652065
b880ebe
0f9f7e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/api-v4": Upcoming Features | ||
| --- | ||
|
|
||
| Reserved IPs: Added new API endpoints ([#13517](https://github.com/linode/manager/pull/13517)) |
|
grevanak-akamai marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,23 @@ | ||
| export interface AssignedEntity { | ||
| id: number; | ||
| label: string; | ||
| type: string; | ||
| url: string; | ||
| } | ||
|
|
||
| export interface IPAddress { | ||
| address: string; | ||
| assigned_entity: AssignedEntity | null; | ||
| gateway: null | string; | ||
| interface_id: null | number; | ||
| linode_id: number; | ||
| linode_id: null | number; | ||
| prefix: number; | ||
| public: boolean; | ||
| rdns: null | string; | ||
| region: string; | ||
| reserved: boolean; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That should be fine. After adding customer tag, I see reserved field is available all the time. So our types file still matches API response. If we add customer tag and still the field is shown optionally, then it makes sense to make it an optional field in our types file. |
||
| subnet_mask: string; | ||
| tags: string[]; | ||
| type: string; | ||
|
grevanak-akamai marked this conversation as resolved.
|
||
| vpc_nat_1_1?: null | { | ||
| address: string; | ||
|
|
@@ -16,6 +26,14 @@ export interface IPAddress { | |
| }; | ||
| } | ||
|
|
||
| export interface AllocateIPPayload { | ||
| linode_id?: number; | ||
| public: boolean; | ||
| region?: string; | ||
| reserved?: boolean; | ||
| type: string; | ||
| } | ||
|
|
||
| export interface IPRangeBaseData { | ||
| prefix: number; | ||
| range: string; | ||
|
|
@@ -51,3 +69,8 @@ export interface CreateIPv6RangePayload { | |
| prefix_length: IPv6Prefix; | ||
| route_target?: string; | ||
| } | ||
|
|
||
| export interface ReserveIPPayload { | ||
| region: string; | ||
| tags?: string[]; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/manager": Upcoming Features | ||
| --- | ||
|
|
||
| Reserved IPs - Add new endpoints, types and Queries ([#13517](https://github.com/linode/manager/pull/13517)) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/queries": Upcoming Features | ||
| --- | ||
|
|
||
| Reserved IPs: Added queries for Reserved IPs ([#13517](https://github.com/linode/manager/pull/13517)) |

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the folder name should be networking-ips
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is existing folder. So keeping it as is to avoid any regression impact.