-
Notifications
You must be signed in to change notification settings - Fork 400
upcoming: [UIE-10429] - Reserved IP: Implement Empty Landing state. #13521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tanushree-akamai
wants to merge
2
commits into
linode:develop
Choose a base branch
from
tanushree-akamai:feature/UIE-10429-ReservedIP-empty-landing-state
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+106
β0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
packages/manager/.changeset/pr-13521-upcoming-features-1774341582397.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/manager": Upcoming Features | ||
| --- | ||
|
|
||
| Implement Empty Landing State for Reserve IP ([#13521](https://github.com/linode/manager/pull/13521)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
...ages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingEmptyState.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import * as React from 'react'; | ||
|
|
||
| import NetworkingIcon from 'src/assets/icons/entityIcons/networking.svg'; | ||
| import { DocumentTitleSegment } from 'src/components/DocumentTitle'; | ||
| import { ResourcesSection } from 'src/components/EmptyLandingPageResources/ResourcesSection'; | ||
|
|
||
| import { | ||
| gettingStartedGuides, | ||
| headers, | ||
| linkAnalyticsEvent, | ||
| youtubeLinkData, | ||
| } from './ReservedIpsLandingEmptyStateData'; | ||
|
|
||
| export const ReservedIpsLandingEmptyState = () => { | ||
| return ( | ||
| <React.Fragment> | ||
| <DocumentTitleSegment segment="Reserved IP Addresses" /> | ||
| <ResourcesSection | ||
| buttonProps={[ | ||
| { | ||
| children: 'Reserve an IP Address', | ||
| onClick: () => { | ||
| // TODO: Open Reserve IP create drawer once ready | ||
|
Check warning on line 23 in packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingEmptyState.tsx
|
||
| }, | ||
| }, | ||
| ]} | ||
| descriptionMaxWidth={500} | ||
| gettingStartedGuidesData={gettingStartedGuides} | ||
| headers={headers} | ||
| icon={NetworkingIcon} | ||
| linkAnalyticsEvent={linkAnalyticsEvent} | ||
| wide={true} | ||
| youtubeLinkData={youtubeLinkData} | ||
| /> | ||
| </React.Fragment> | ||
| ); | ||
| }; | ||
56 changes: 56 additions & 0 deletions
56
...s/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingEmptyStateData.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import { | ||
| docsLink, | ||
| youtubeChannelLink, | ||
| youtubeMoreLinkText, | ||
| } from 'src/utilities/emptyStateLandingUtils'; | ||
|
|
||
| import type { | ||
| ResourcesHeaders, | ||
| ResourcesLinks, | ||
| ResourcesLinkSection, | ||
| } from 'src/components/EmptyLandingPageResources/ResourcesLinksTypes'; | ||
|
|
||
| export const headers: ResourcesHeaders = { | ||
| description: | ||
| 'Reserve and manage public IPv4 addresses across regions, and assign them to resources like Linodes or NodeBalancers when needed.', | ||
| subtitle: 'Dedicated IP addressing for your cloud resources', | ||
| title: 'Reserved IP Addresses', | ||
| }; | ||
|
|
||
| export const gettingStartedGuides: ResourcesLinkSection = { | ||
| links: [ | ||
| { | ||
| text: 'Overview of Reserved IPs', | ||
| to: 'https://www.linode.com/docs/', // To be updated with actual Reserved IPs documentation link once available | ||
|
Check warning on line 24 in packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingEmptyStateData.ts
|
||
| }, | ||
| { | ||
| text: 'Getting Started with Reserved IPs', | ||
| to: 'https://www.linode.com/docs/', // To be updated with actual Reserved IPs documentation link once available | ||
| }, | ||
| { | ||
| text: 'Managing and Assigning Reserved IPs', | ||
| to: 'https://www.linode.com/docs/', // To be updated with actual Reserved IPs documentation link once available | ||
| }, | ||
| ], | ||
| moreInfo: { | ||
| text: 'View additional Reserved IP documentation', | ||
| to: docsLink, | ||
| }, | ||
| title: 'Getting Started Guides', | ||
| }; | ||
|
|
||
| export const youtubeLinkData: ResourcesLinkSection = { | ||
| links: [ | ||
| // To be added once we have Reserved IPs specific YouTube content | ||
| ], | ||
| moreInfo: { | ||
| text: youtubeMoreLinkText, | ||
| to: youtubeChannelLink, | ||
| }, | ||
| title: 'Video Playlist', | ||
| }; | ||
|
|
||
| export const linkAnalyticsEvent: ResourcesLinks['linkAnalyticsEvent'] = { | ||
| action: 'Click:link', | ||
| category: 'Reserved IPs landing page empty', | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there are no YT videos and it isn't clear at this point if there will be, I think it's better to remove that section by not passing that prop.