FIX: Users failed to log in when the username changes#144
Closed
small-lovely-cat wants to merge 1 commit intolinux-do:masterfrom
Closed
FIX: Users failed to log in when the username changes#144small-lovely-cat wants to merge 1 commit intolinux-do:masterfrom
small-lovely-cat wants to merge 1 commit intolinux-do:masterfrom
Conversation
Author
|
@yyg-max 来看看喵 owo |
small-lovely-cat
force-pushed
the
fix-oauth-rename
branch
from
a4d1ae3 to
d88915d
Compare
small-lovely-cat
force-pushed
the
fix-oauth-rename
branch
from
d88915d to
bee8d5f
Compare
Collaborator
|
不是这个问题 已经改了好 #145 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
例行检查
关联信息
Ref: t/-/1489265
变更内容
修复当用户更换OAuth中的用户名时，无法登录的问题。
变更原因
else if errors.Is(txByUsername.Error, gorm.ErrRecordNotFound)这里条件写错了，应该是找不到ID才创建新用户，而不是找不到Username，然后逻辑就跑到创建新用户里面去了 owo
还有一个error handler好像也有点问题，一起改了 owo