Skip to content

FIX: Users failed to log in when the username changes #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
small-lovely-cat wants to merge 1 commit into from
Closed

FIX: Users failed to log in when the username changes #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/apps/oauth/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func doOAuth(ctx context.Context, code string) (*User, error) {
span.SetStatus(codes.Error, err.Error())
return nil, err
}
} else if errors.Is(txByUsername.Error, gorm.ErrRecordNotFound) {
} else if errors.Is(txByID.Error, gorm.ErrRecordNotFound) {
user = User{
ID: userInfo.Id,
Username: userInfo.Username,
Expand All @@ -140,8 +140,8 @@ func doOAuth(ctx context.Context, code string) (*User, error) {
user.EnqueueBadgeScoreTask(ctx)
} else {
// query failed
span.SetStatus(codes.Error, txByUsername.Error.Error())
return nil, txByUsername.Error
span.SetStatus(codes.Error, txByID.Error.Error())
return nil, txByID.Error
}
} else {
if user.ID != userInfo.Id {
Expand Down