extensions: Make register/unregisterTrayIconReplacement multi-instance compatible.#13680
Draft
mtwebster wants to merge 1 commit intolinuxmint:masterfrom
Draft
extensions: Make register/unregisterTrayIconReplacement multi-instance compatible.#13680mtwebster wants to merge 1 commit intolinuxmint:masterfrom
mtwebster wants to merge 1 commit intolinuxmint:masterfrom
Conversation
instance compatible. Most applets are already compatible, mark them so. Remaining ones are: - notifications (linuxmint#13248) - legacy systray applet. Only a couple of third-party applets make use of the tray-icon- replacement functions. - The network applet sends its own notifications currently, and we'd end up with multiples. Possibly some of the network code can be put in a shared class/instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most applets are already compatible, mark them so. Remaining ones
are:
Only a couple of third-party applets make use of the tray-icon-
replacement functions.
end up with multiples. Possibly some of the network code can be
put in a shared class/instance.