Merged
Conversation
Collaborator
|
Given how simple this is, I would consider writing more generic code that, for each type, returns the default value for the expression. If there is none, it fails with the current exception. |
CatarinaGamboa
requested changes
Jul 27, 2025
| import liquidjava.specification.StateRefinement; | ||
|
|
||
| @Ghost("boolean opened") | ||
| @Ghost("boolean closed") |
Collaborator
There was a problem hiding this comment.
is there a reason for having open and closed instead of just using opened and !opened?
If you want to test two different ghost variables do not use opposite ghost variables
| closed = true; | ||
| } | ||
|
|
||
| @StateRefinement(from = "opened(this) && closed(this)") |
Collaborator
There was a problem hiding this comment.
related to the one before - it does not make sense to require open and closed at the same time
Merged
Collaborator
|
@rodrigomilisse are you still planning on making changes here before we merge? |
Collaborator
|
Also added support for |
CatarinaGamboa
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added basic support for boolean ghost variables. Only tested in trivial case