Add RP2040 and STM32 support to build.sh#1603
Open
oltaco wants to merge 2 commits intomeshcore-dev:devfrom
Open
Add RP2040 and STM32 support to build.sh#1603oltaco wants to merge 2 commits intomeshcore-dev:devfrom
oltaco wants to merge 2 commits intomeshcore-dev:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GithHub builds for RP2040 and STM32 environements are failing due to build.sh trying to run mergebin on them.
This PR adds a function get_platform_for_env() to get the build platform from the pio config for the environment that we are building and uses that for post-build actions so that we can copy the correct files to /out. It also adds -D ESP32_PLATFORM to esp32_base so that we can target those builds in the post-build actions.
It does rely on jq which is included as part of the ubuntu-latest runner that the GitHub builds use, but it might be worth adding jq to .github/actions/setup-build-environment/action.yml
@liamcottle You're the master, can you take a look?