.NET: [Bug]: CopySessionConfig() hardcodes Streaming = true, ignoring SessionConfig.Streaming value#4775
Open
feiyun0112 wants to merge 3 commits intomicrosoft:mainfrom
Open
.NET: [Bug]: CopySessionConfig() hardcodes Streaming = true, ignoring SessionConfig.Streaming value#4775feiyun0112 wants to merge 3 commits intomicrosoft:mainfrom
feiyun0112 wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes GitHub Copilot agent session config copying to respect the caller-provided SessionConfig.Streaming value (instead of hardcoding streaming on), aligning the .NET GitHub Copilot provider with SessionConfig semantics and unblocking scenarios where streaming must be disabled (issue #4732).
Changes:
- Update
GitHubCopilotAgent.CopySessionConfigto copyStreamingfrom the source config. - Update
GitHubCopilotAgent.CopyResumeSessionConfigto preservesource.Streaming(defaulting totrueonly whensourceisnull). - Extend unit tests to cover
Streaming=truein existing copy tests and add new tests assertingStreaming=falseis preserved.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.GitHub.Copilot/GitHubCopilotAgent.cs | Preserve Streaming when copying session configs; update XML docs accordingly. |
| dotnet/tests/Microsoft.Agents.AI.GitHub.Copilot.UnitTests/GitHubCopilotAgentTests.cs | Add/adjust unit tests to validate Streaming preservation behavior in copy helpers. |
dotnet/tests/Microsoft.Agents.AI.GitHub.Copilot.UnitTests/GitHubCopilotAgentTests.cs
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4732
Note
since the default value of SessionConfig.Streaming is false, after this change, all instances creating a new SessionConfig must explicitly set Streaming = true. This will affect existing code that is already in use.