Skip to content

.NET: [Bug]: CopySessionConfig() hardcodes Streaming = true, ignoring SessionConfig.Streaming value #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feiyun0112 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

.NET: [Bug]: CopySessionConfig() hardcodes Streaming = true, ignoring SessionConfig.Streaming value #4775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0e2e64
explicitly streaming
feiyun0112 Mar 19, 2026
55402ad
Potential fix for pull request finding
feiyun0112 Mar 19, 2026
b31a0fe
Merge branch 'main' into issues/4732
feiyun0112 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions dotnet/src/Microsoft.Agents.AI.GitHub.Copilot/GitHubCopilotAgent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,9 @@ private ResumeSessionConfig CreateResumeConfig()
}

/// <summary>
/// Copies all supported properties from a source <see cref="SessionConfig"/> into a new instance
/// with <see cref="SessionConfig.Streaming"/> set to <c>true</c>.
/// Copies all supported properties from a source <see cref="SessionConfig"/> into a new instance,
/// preserving the <see cref="SessionConfig.Streaming"/> value from <paramref name="source"/> when set.
/// When <paramref name="source"/> has no explicit <see cref="SessionConfig.Streaming"/> value, streaming defaults to <c>true</c>.
/// </summary>
internal static SessionConfig CopySessionConfig(SessionConfig source)
{
Expand All @@ -298,13 +299,14 @@ internal static SessionConfig CopySessionConfig(SessionConfig source)
SkillDirectories = source.SkillDirectories,
DisabledSkills = source.DisabledSkills,
InfiniteSessions = source.InfiniteSessions,
Streaming = true
Streaming = source.Streaming ?? true
};
}

/// <summary>
/// Copies all supported properties from a source <see cref="SessionConfig"/> into a new
/// <see cref="ResumeSessionConfig"/> with <see cref="ResumeSessionConfig.Streaming"/> set to <c>true</c>.
/// <see cref="ResumeSessionConfig"/>, preserving the <see cref="SessionConfig.Streaming"/> value
/// from <paramref name="source"/>. When <paramref name="source"/> is <c>null</c>, streaming defaults to <c>true</c>.
/// </summary>
internal static ResumeSessionConfig CopyResumeSessionConfig(SessionConfig? source)
{
Expand All @@ -327,7 +329,7 @@ internal static ResumeSessionConfig CopyResumeSessionConfig(SessionConfig? sourc
SkillDirectories = source?.SkillDirectories,
DisabledSkills = source?.DisabledSkills,
InfiniteSessions = source?.InfiniteSessions,
Streaming = true
Streaming = source?.Streaming ?? true
};
}

Expand Down
36 changes: 36 additions & 0 deletions dotnet/tests/Microsoft.Agents.AI.GitHub.Copilot.UnitTests/GitHubCopilotAgentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ public void CopySessionConfig_CopiesAllProperties()
OnUserInputRequest = userInputHandler,
McpServers = mcpServers,
DisabledSkills = ["skill1"],
Streaming = true,
};

// Act
Expand Down Expand Up @@ -180,6 +181,7 @@ public void CopyResumeSessionConfig_CopiesAllProperties()
OnUserInputRequest = userInputHandler,
McpServers = mcpServers,
DisabledSkills = ["skill1"],
Streaming = true,
};

// Act
Expand Down Expand Up @@ -222,6 +224,40 @@ public void CopyResumeSessionConfig_WithNullSource_ReturnsDefaults()
Assert.True(result.Streaming);
}

[Fact]
public void CopySessionConfig_WithStreamingFalse_PreservesStreamingFalse()
{
// Arrange — caller explicitly disables streaming (issue #4732)
var source = new SessionConfig
{
Streaming = false,
SystemMessage = new SystemMessageConfig { Mode = SystemMessageMode.Append, Content = "You are a helpful assistant." },
};

// Act
SessionConfig result = GitHubCopilotAgent.CopySessionConfig(source);

// Assert
Assert.False(result.Streaming);
}

[Fact]
public void CopyResumeSessionConfig_WithStreamingFalse_PreservesStreamingFalse()
{
// Arrange — caller explicitly disables streaming (issue #4732)
var source = new SessionConfig
{
Streaming = false,
SystemMessage = new SystemMessageConfig { Mode = SystemMessageMode.Append, Content = "You are a helpful assistant." },
};

// Act
ResumeSessionConfig result = GitHubCopilotAgent.CopyResumeSessionConfig(source);

// Assert
Assert.False(result.Streaming);
}

[Fact]
public void ConvertToAgentResponseUpdate_AssistantMessageEvent_DoesNotEmitTextContent()
{
Expand Down