Microbenchmark: upgrade Intel MLC to v3.12 in rocm5.0.x#784
Microbenchmark: upgrade Intel MLC to v3.12 in rocm5.0.x#784
Conversation
Align rocm5.0.x.dockerfile with other dockerfiles by upgrading Intel Memory Latency Checker from v3.11 to v3.12. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Upgrades Intel Memory Latency Checker (MLC) in the ROCm 5.0.x Dockerfile to v3.12 to match other images.
Changes:
- Bump Intel MLC download from v3.11 to v3.12 by updating the tarball URL.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RUN cd /tmp && \ | ||
| wget -q https://downloadmirror.intel.com/793041/mlc_v3.11.tgz -O mlc.tgz && \ | ||
| wget -q https://downloadmirror.intel.com/866182/mlc_v3.12.tgz -O mlc.tgz && \ | ||
| tar xzf mlc.tgz Linux/mlc && \ | ||
| cp ./Linux/mlc /usr/local/bin/ && \ | ||
| rm -rf ./Linux mlc.tgz |
There was a problem hiding this comment.
The build downloads and executes a vendor-provided binary without any integrity verification. Since this PR changes the artifact being fetched, it’d be safer to pin and verify the download (e.g., publish and check a SHA256 checksum, or use signed artifacts if Intel provides them) before extracting/copying to /usr/local/bin.
polarG
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
=======================================
Coverage 85.70% 85.70%
=======================================
Files 102 102
Lines 7703 7703
=======================================
Hits 6602 6602
Misses 1101 1101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guoshzhao
added
benchmarks
Summary