Skip to content

Microbenchmark: upgrade Intel MLC to v3.12 in rocm5.0.x #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
polarG wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Microbenchmark: upgrade Intel MLC to v3.12 in rocm5.0.x #784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dockerfile/rocm5.0.x.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ RUN cd /tmp && \

# Install Intel MLC
RUN cd /tmp && \
wget -q https://downloadmirror.intel.com/793041/mlc_v3.11.tgz -O mlc.tgz && \
wget -q https://downloadmirror.intel.com/866182/mlc_v3.12.tgz -O mlc.tgz && \
tar xzf mlc.tgz Linux/mlc && \
cp ./Linux/mlc /usr/local/bin/ && \
rm -rf ./Linux mlc.tgz
Comment on lines 100 to 104
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build downloads and executes a vendor-provided binary without any integrity verification. Since this PR changes the artifact being fetched, it’d be safer to pin and verify the download (e.g., publish and check a SHA256 checksum, or use signed artifacts if Intel provides them) before extracting/copying to /usr/local/bin.

Copilot uses AI. Check for mistakes.
Expand Down
Loading