Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the API and backend logic for deleting containers to provide more informative and consistent responses, especially for API clients. The main improvements are the switch from a 204 to a 200 response with a JSON body for successful deletions, better error handling with appropriate status codes and messages, and alignment between the OpenAPI spec and backend implementation.
API Response Improvements
openapi.yaml) now documents a 200 response with a JSON body (including a success message and DNS warnings) for successful container deletions, instead of a 204 with no content. It also adds a 400 response for bad requests.routers/containers.js) now returns a 200 JSON response with a message and DNS warnings on successful API deletes, matching the updated spec.Error Handling Enhancements
Consistency and Code Clean-up