✨feat: add RenderScoreTableANSI to highlight column maxes#2278
Merged
✨feat: add RenderScoreTableANSI to highlight column maxes#2278
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to support the new RenderScoreTableANSI helper by documenting how the ANSI-rendered score table behaves (highlighting/columns).
Changes:
- Added a doc comment for
RenderScoreTableANSIdescribing the ANSI output and optional Diff column.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| btv int | ||
| } | ||
|
|
||
| // RenderScoreTableANSI renders the score table in an ANSI code block, highlighting the max value in each column. If includeDiff is true, includes the Diff column. |
There was a problem hiding this comment.
The doc comment is a bit misleading/incomplete: includeDiff only controls whether the Diff column is rendered, but Diff values aren’t highlighted based on the column max (they’re colored green/red by sign). Also, whether Contr/TmWk/BTV columns are included depends on srmode, which isn’t mentioned. Please update the comment to reflect the actual coloring/column behavior.
Suggested change
| // RenderScoreTableANSI renders the score table in an ANSI code block, highlighting the max value in each column. If includeDiff is true, includes the Diff column. | |
| // RenderScoreTableANSI renders the score table in an ANSI code block. When srmode | |
| // is true, the Contr, TmWk, and BTV columns are included in addition to Name/CXP. | |
| // The numeric columns (CXP, Contr, TmWk, BTV) are highlighted based on the maximum | |
| // value in their respective columns. If includeDiff is true, a Diff column is | |
| // rendered whose values are colored green or red based on sign, not on the column | |
| // maximum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.