Skip to content

✨feat: add RenderScoreTableANSI to highlight column maxes #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkmccarty merged 1 commit into from
Mar 21, 2026
+1 −0
Merged

✨feat: add RenderScoreTableANSI to highlight column maxes #2278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/boost/estimate_scores.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,7 @@ type srPeaks struct {
btv int
}

// RenderScoreTableANSI renders the score table in an ANSI code block, highlighting the max value in each column. If includeDiff is true, includes the Diff column.
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc comment is a bit misleading/incomplete: includeDiff only controls whether the Diff column is rendered, but Diff values aren’t highlighted based on the column max (they’re colored green/red by sign). Also, whether Contr/TmWk/BTV columns are included depends on srmode, which isn’t mentioned. Please update the comment to reflect the actual coloring/column behavior.

Suggested change
// RenderScoreTableANSI renders the score table in an ANSI code block, highlighting the max value in each column. If includeDiff is true, includes the Diff column.
// RenderScoreTableANSI renders the score table in an ANSI code block. When srmode
// is true, the Contr, TmWk, and BTV columns are included in addition to Name/CXP.
// The numeric columns (CXP, Contr, TmWk, BTV) are highlighted based on the maximum
// value in their respective columns. If includeDiff is true, a Diff column is
// rendered whose values are colored green or red based on sign, not on the column
// maximum.

Copilot uses AI. Check for mistakes.
func RenderScoreTableANSI(rows []srRow, srmode bool, includeDiff bool) string {
peaks := computePeaks(rows)

Expand Down
Loading