Skip building tests when BUILD_TESTING=OFF#1139
Open
kevinAlbs wants to merge 2 commits intomongodb:masterfrom
Open
Skip building tests when BUILD_TESTING=OFF#1139kevinAlbs wants to merge 2 commits intomongodb:masterfrom
BUILD_TESTING=OFF#1139kevinAlbs wants to merge 2 commits intomongodb:masterfrom
Conversation
Intended to work around error untarring paths with two dots.
Comment on lines
+104
to
+110
| if [[ "${BUILD_TESTING:?}" =~ ^(0|OFF|NO|FALSE|n|off|no|false)$ ]]; then | ||
| echo "Skipping tests since BUILD_TESTING is false" | ||
| exit 0; | ||
| fi | ||
|
|
||
| _cmake_with_env --build "$BINARY_DIR" --target test-mongocrypt test_kms_request | ||
| run_chdir "$BINARY_DIR" run_ctest |
Contributor
There was a problem hiding this comment.
Ideally, BUILD_TESTING=TRUE should add the test targets as default build targets, and this branch would be unnecessary. Is the branch required?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip building tests when
BUILD_TESTING=OFFBackground & Motivation
Attempting to update the C driver to use a newer libmongocrypt resulted in an error on Windows:
The failure to untar a path with two dots is reported in DEVPROD-30287. The path being untarred is part of the test build. As a workaround, this PR skips building more test executables when
BUILD_TESTING=OFF. With this PR applied, updating libmongocrypt the C driver succeeds to extract a produced tarball.