Skip to content

fix(macOS): Fix background update check incorrectly calling Sparkle when automaticallyChecksForUpdates is NO #9744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i2h3 merged 1 commit into from
Mar 31, 2026
+18 −5
Merged

fix(macOS): Fix background update check incorrectly calling Sparkle when automaticallyChecksForUpdates is NO #9744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/gui/updater/sparkleupdater_mac.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ - (NSString *)feedURLStringForUpdater:(SPUUpdater *)updater
// See https://github.com/owncloud/client/issues/2931
NSString *bundlePath = [[NSBundle mainBundle] bundlePath];
NSString *expectedPath = [NSString stringWithFormat:@"/Applications/%@", [bundlePath lastPathComponent]];

if (![expectedPath isEqualTo:bundlePath]) {
qCWarning(lcUpdater) << "We are not in /Applications, won't check for update!";
return false;
Expand All @@ -289,13 +290,25 @@ - (NSString *)feedURLStringForUpdater:(SPUUpdater *)updater

void SparkleUpdater::backgroundCheckForUpdate()
{
if (!autoUpdaterAllowed()) {
qCInfo(OCC::lcUpdater) << "not launching background check, auto updater not allowed";
return;
}

const ConfigFile config;
if (autoUpdaterAllowed() && config.autoUpdateCheck()) {
qCInfo(OCC::lcUpdater) << "launching background check";
[_interface->updaterController.updater checkForUpdatesInBackground];
} else {
qCInfo(OCC::lcUpdater) << "not launching background check, auto updater not allowed or update check skipped in config";

if (!config.autoUpdateCheck()) {
qCInfo(OCC::lcUpdater) << "not launching background check, update check skipped in config";
return;
}

if (!_interface->updaterController.updater.automaticallyChecksForUpdates) {
qCInfo(OCC::lcUpdater) << "not launching background check, automaticallyChecksForUpdates is disabled";
return;
}

qCInfo(OCC::lcUpdater) << "launching background check";
[_interface->updaterController.updater checkForUpdatesInBackground];
}

QString SparkleUpdater::statusString() const
Expand Down
Loading