fix(macOS): Fix background update check incorrectly calling Sparkle when automaticallyChecksForUpdates is NO

[i2h3]

Fixes #9662

Problem

On macOS, Sparkle would log the following warning at startup:

"Calling -[SPUUpdater checkForUpdatesInBackground] for your own bundle when Sparkle is set to ask the user permission to check for updates in the background automatically and when automaticallyChecksForUpdates is NO leads to incorrect behavior."

This happened because backgroundCheckForUpdate() called checkForUpdatesInBackground relying solely on Nextcloud's own config (autoUpdateCheck) — without consulting Sparkle's own automaticallyChecksForUpdates property. The two settings have independent sources of truth: config.autoUpdateCheck() reads from Nextcloud's QSettings-backed config file, while automaticallyChecksForUpdates is managed by Sparkle in NSUserDefaults and reflects whether Sparkle has been initialised and granted permission by the user. They can diverge, for example on a fresh install before Sparkle has shown its first-run permission prompt.

Fix

• Added automaticallyChecksForUpdates as a third guard in backgroundCheckForUpdate(), preventing the call to checkForUpdatesInBackground when Sparkle is not in a state to handle it.
• Refactored the single compound if/else into individual early-return guard blocks (each with its own log message) so that logs precisely identify which condition prevented the background check from running.

[i2h3]

/backport to stable-4.0

[Copilot]

Pull request overview

Fixes a macOS startup warning by preventing SPUUpdater::checkForUpdatesInBackground from being called when Sparkle itself is not configured/allowed to perform automatic background checks (automaticallyChecksForUpdates == NO), which can diverge from Nextcloud’s own config on fresh installs.

Changes:

• Adds a Sparkle-side guard (automaticallyChecksForUpdates) before running background update checks.
• Refactors backgroundCheckForUpdate() into early-return guards with more specific log messages.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Artifact containing the AppImage: nextcloud-appimage-pr-9744.zip

Digest: sha256:e7d2493c37a32c88b2f9ab7735229561049bf0d27736b20e2ad774d3362665fd

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[i2h3]

/backport to stable-33.0