Skip to content

lib: improve argument handling in Blob constructor#61980

Open
Ms2ger wants to merge 1 commit intonodejs:mainfrom
Ms2ger:blob-dictionary
Open

lib: improve argument handling in Blob constructor#61980
Ms2ger wants to merge 1 commit intonodejs:mainfrom
Ms2ger:blob-dictionary

Conversation

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Feb 25, 2026

As specified in WebIDL (https://webidl.spec.whatwg.org/#js-dictionary), the fields of a dictionary need to be read in lexicographical order.

As specified in WebIDL (<https://webidl.spec.whatwg.org/#js-dictionary>),
the fields of a dictionary need to be read in lexicographical order.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 25, 2026
@jazelly jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2026
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@Renegade334 Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. web-standards Issues and PRs related to Web APIs commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 25, 2026
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (e0375be) to head (a756b85).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61980      +/-   ##
==========================================
- Coverage   91.71%   89.77%   -1.95%     
==========================================
  Files         337      674     +337     
  Lines      140263   205694   +65431     
  Branches    21785    39432   +17647     
==========================================
+ Hits       128649   184657   +56008     
- Misses      11392    13279    +1887     
- Partials      222     7758    +7536     
Files with missing lines Coverage Δ
lib/internal/blob.js 100.00% <100.00%> (ø)

... and 456 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. web-standards Issues and PRs related to Web APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants