Skip to content

lib: improve argument handling in Blob constructor #61980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ms2ger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: improve argument handling in Blob constructor #61980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/blob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ class Blob {
}
validateDictionary(options, 'options');
let {
type = '',
endings = 'transparent',
type = '',
} = options ?? kEmptyObject;

endings = `${endings}`;
Expand Down
1 change: 0 additions & 1 deletion test/wpt/status/FileAPI/blob.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"blobParts not an object: BigInt with BigInt.prototype[Symbol.iterator]",
"blobParts not an object: Symbol with Symbol.prototype[Symbol.iterator]",
"Getters and value conversions should happen in order until an exception is thrown.",
"options properties should be accessed in lexicographic order.",
"Arguments should be evaluated from left to right."
],
"flaky": [
Expand Down
Loading