OCPBUGS-64842: Disable LoadBalancer in cloud config when Octavia is unavailable by eshulman2 · Pull Request #10326 · openshift/installer

eshulman2 · 2026-02-23T09:33:13Z

When Octavia (load-balancer) endpoint is not available in the OpenStack service catalog, explicitly set [LoadBalancer] enabled = false in the cloud provider config. This prevents the Cloud Controller Manager from crashing on startup due to an upstream change in cloud-provider-openstack that changed error handling from klog.Errorf to klog.Fatalf when the LoadBalancer client cannot be created.

The fix uses the same pattern already established in the cluster destroy code (pkg/destroy/openstack/openstack.go) to detect Octavia availability by checking for gophercloud.ErrEndpointNotFound.

related to: https://issues.redhat.com/browse/OCPBUGS-64842

Summary by CodeRabbit

Release Notes

New Features
- Enhanced OpenStack Octavia load balancer service detection to automatically configure load balancer support based on availability
- Added PowerVC platform support with appropriate configuration handling

stephenfin

I think this approach makes sense. One vaguely-related comment inline

pkg/asset/manifests/openstack/cloudproviderconfig.go

eshulman2 · 2026-02-23T14:59:37Z

/retest

eshulman2 · 2026-02-24T06:59:44Z

/retest

…ilable When Octavia (load-balancer) endpoint is not available in the OpenStack service catalog, explicitly set [LoadBalancer] enabled = false in the cloud provider config. This prevents the Cloud Controller Manager from crashing on startup due to an upstream change in cloud-provider-openstack that changed error handling from klog.Errorf to klog.Fatalf when the LoadBalancer client cannot be created. The fix uses the same pattern already established in the cluster destroy code (pkg/destroy/openstack/openstack.go) to detect Octavia availability by checking for gophercloud.ErrEndpointNotFound. Fixes: https://issues.redhat.com/browse/OCPBUGS-64842 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

eshulman2 · 2026-02-25T07:05:57Z

/retest

eshulman2 · 2026-02-25T14:57:19Z

/test e2e-openstack-proxy

eshulman2 · 2026-02-26T07:59:12Z

/test e2e-openstack-ovn

stephenfin · 2026-02-26T15:36:49Z

/approve
/lgtm

stephenfin · 2026-02-26T15:38:07Z

The CI failure was due to [Monitor:legacy-test-framework-invariants-alerts][bz-etcd][invariant] alert/etcdMemberCommunicationSlow should not be at or above info. That's just slow disk on the cloud we're using.

eshulman2 · 2026-03-04T10:49:47Z

/jira refresh

openshift-ci-robot · 2026-03-04T10:49:50Z

@eshulman2: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-04T11:00:37Z

@eshulman2: This pull request references Jira Issue OCPBUGS-64842, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When Octavia (load-balancer) endpoint is not available in the OpenStack service catalog, explicitly set [LoadBalancer] enabled = false in the cloud provider config. This prevents the Cloud Controller Manager from crashing on startup due to an upstream change in cloud-provider-openstack that changed error handling from klog.Errorf to klog.Fatalf when the LoadBalancer client cannot be created.

The fix uses the same pattern already established in the cluster destroy code (pkg/destroy/openstack/openstack.go) to detect Octavia availability by checking for gophercloud.ErrEndpointNotFound.

related to: https://issues.redhat.com/browse/OCPBUGS-64842

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

eshulman2 · 2026-03-04T11:01:49Z

/jira refresh

openshift-ci-robot · 2026-03-04T11:01:56Z

@eshulman2: This pull request references Jira Issue OCPBUGS-64842, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-16T11:03:38Z

@mandre: mandre unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/prow/e2e-openstack-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mandre · 2026-03-16T11:05:54Z

OK, let's give the e2e-openstack-proxy job one more chance before we ask someone else to override.
/retest-required

mandre · 2026-03-16T11:27:47Z

/verified later eshulman

eshulman2 · 2026-03-16T13:38:43Z

/test e2e-openstack-proxy

mandre · 2026-03-16T14:11:53Z

/verified later eshulman

openshift-ci-robot · 2026-03-16T14:12:06Z

@mandre: Only users can be targets for the /verified later command.

Details

In response to this:

/verified later eshulman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mandre · 2026-03-16T14:13:04Z

/verified later @eshulman2

openshift-ci-robot · 2026-03-16T14:13:19Z

@mandre: This PR has been marked to be verified later by @eshulman2.

Details

In response to this:

/verified later @eshulman2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

patrickdillon · 2026-03-16T15:59:42Z

/override ci/prow/e2e-openstack-ovn

patrickdillon · 2026-03-16T15:59:56Z

override due to known etcd infrastructure issue

openshift-ci · 2026-03-16T16:04:37Z

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-openstack-ovn

Details

In response to this:

/override ci/prow/e2e-openstack-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tthvo · 2026-03-16T18:51:17Z

/test gofmt govet unit verify-deps yaml-lint

patrickdillon · 2026-03-16T20:57:21Z

/override ci/prow/okd-scos-images

unrelated infra issue

openshift-ci · 2026-03-16T20:57:45Z

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

unrelated infra issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-03-16T20:57:47Z

@eshulman2: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-03-16T21:00:34Z

@eshulman2: Jira Issue OCPBUGS-64842: All pull requests linked via external trackers have merged:

openshift/installer#10326

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-64842 has been moved to the MODIFIED state.

Details

In response to this:

When Octavia (load-balancer) endpoint is not available in the OpenStack service catalog, explicitly set [LoadBalancer] enabled = false in the cloud provider config. This prevents the Cloud Controller Manager from crashing on startup due to an upstream change in cloud-provider-openstack that changed error handling from klog.Errorf to klog.Fatalf when the LoadBalancer client cannot be created.

The fix uses the same pattern already established in the cluster destroy code (pkg/destroy/openstack/openstack.go) to detect Octavia availability by checking for gophercloud.ErrEndpointNotFound.

related to: https://issues.redhat.com/browse/OCPBUGS-64842

Summary by CodeRabbit

Release Notes

New Features

Enhanced OpenStack Octavia load balancer service detection to automatically configure load balancer support based on availability

Added PowerVC platform support with appropriate configuration handling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mandre · 2026-03-17T06:31:32Z

/jira cherrypick release-4.21,release-4.20

eshulman2 · 2026-03-17T07:59:38Z

/jira cherrypick release-4.21,release-4.20

eshulman2 · 2026-03-17T09:43:19Z

/cherrypick release-4.21,release-4.20

openshift-cherrypick-robot · 2026-03-17T09:45:17Z

@eshulman2: cannot checkout release-4.21,release-4.20: error checking out "release-4.21,release-4.20": exit status 1 error: pathspec 'release-4.21,release-4.20' did not match any file(s) known to git

Details

In response to this:

/cherrypick release-4.21,release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

eshulman2 · 2026-03-17T09:50:41Z

/cherrypick release-4.21

eshulman2 · 2026-03-17T09:50:52Z

/cherrypick release-4.20

openshift-cherrypick-robot · 2026-03-17T09:51:37Z

@eshulman2: new pull request created: #10399

Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-03-17T09:51:56Z

@eshulman2: #10326 failed to apply on top of branch "release-4.20":

Applying: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable
Using index info to reconstruct a base tree...
M	pkg/asset/manifests/openstack/cloudproviderconfig.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/asset/manifests/openstack/cloudproviderconfig.go
CONFLICT (content): Merge conflict in pkg/asset/manifests/openstack/cloudproviderconfig.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 openstack: Disable LoadBalancer in cloud config when Octavia is unavailable

Details

In response to this:

/cherrypick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from mandre and stephenfin February 23, 2026 09:34

stephenfin reviewed Feb 23, 2026

View reviewed changes

pkg/asset/manifests/openstack/cloudproviderconfig.go Show resolved Hide resolved

eshulman2 force-pushed the fix-ocpbugs-64842 branch from 2d03a44 to 91529ff Compare February 24, 2026 17:30

eshulman2 requested a review from stephenfin February 24, 2026 17:31

eshulman2 force-pushed the fix-ocpbugs-64842 branch from 91529ff to 340389a Compare February 24, 2026 17:58

eshulman2 changed the title ~~openstack: Disable LoadBalancer in cloud config when Octavia is unavailable~~ OCPBUGS-64842 openstack: Disable LoadBalancer in cloud config when Octavia is unavailable Feb 25, 2026

openshift-ci bot assigned stephenfin Feb 26, 2026

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 26, 2026

eshulman2 changed the title ~~OCPBUGS-64842 openstack: Disable LoadBalancer in cloud config when Octavia is unavailable~~ OCPBUGS-64842: Disable LoadBalancer in cloud config when Octavia is unavailable Mar 4, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 4, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 4, 2026

Merge branch 'openshift:main' into fix-ocpbugs-64842

7fcf885

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2026

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Mar 16, 2026

openshift-merge-bot bot merged commit b3e61d0 into openshift:main Mar 16, 2026
19 checks passed

eshulman2 deleted the fix-ocpbugs-64842 branch March 17, 2026 08:07

openshift-cherrypick-robot mentioned this pull request Mar 17, 2026

OCPBUGS-78696: [release-4.21] : Disable LoadBalancer in cloud config when Octavia is unavailable #10399

Open

eshulman2 mentioned this pull request Mar 17, 2026

OCPBUGS-78694: [release-4.20]: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable #10401

Open

Conversation

eshulman2 commented Feb 23, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Uh oh!

stephenfin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eshulman2 commented Feb 23, 2026

Uh oh!

eshulman2 commented Feb 24, 2026

Uh oh!

eshulman2 commented Feb 25, 2026

Uh oh!

eshulman2 commented Feb 25, 2026

Uh oh!

eshulman2 commented Feb 26, 2026

Uh oh!

stephenfin commented Feb 26, 2026

Uh oh!

stephenfin commented Feb 26, 2026

Uh oh!

eshulman2 commented Mar 4, 2026

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

eshulman2 commented Mar 4, 2026

Uh oh!

openshift-ci-robot commented Mar 4, 2026

Uh oh!

openshift-ci bot commented Mar 16, 2026

Uh oh!

mandre commented Mar 16, 2026

Uh oh!

mandre commented Mar 16, 2026

Uh oh!

eshulman2 commented Mar 16, 2026

Uh oh!

mandre commented Mar 16, 2026

Uh oh!

openshift-ci-robot commented Mar 16, 2026

Uh oh!

mandre commented Mar 16, 2026

Uh oh!

openshift-ci-robot commented Mar 16, 2026

Uh oh!

patrickdillon commented Mar 16, 2026

Uh oh!

patrickdillon commented Mar 16, 2026

Uh oh!

openshift-ci bot commented Mar 16, 2026

Uh oh!

tthvo commented Mar 16, 2026

Uh oh!

patrickdillon commented Mar 16, 2026

Uh oh!

openshift-ci bot commented Mar 16, 2026

Uh oh!

openshift-ci bot commented Mar 16, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 16, 2026

Summary by CodeRabbit

Release Notes

Uh oh!

mandre commented Mar 17, 2026

Uh oh!

eshulman2 commented Mar 17, 2026

Uh oh!

eshulman2 commented Mar 17, 2026

Uh oh!

openshift-cherrypick-robot commented Mar 17, 2026

Uh oh!

eshulman2 commented Mar 17, 2026

Uh oh!

eshulman2 commented Mar 17, 2026

eshulman2 commented Feb 23, 2026 •

edited by coderabbitai bot

Loading