Skip to content

[release-4.20] : run resource request/limit check early#30888

Merged
sdodson merged 2 commits intoopenshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-30879-to-release-4.20
Mar 18, 2026
Merged

[release-4.20] : run resource request/limit check early#30888
sdodson merged 2 commits intoopenshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-30879-to-release-4.20

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #30879

/assign sdodson

/cherrypick release-4.19

Add [Early] to the "should set requests but not limits" test so it
runs in the early test bucket before the main parallel test suites.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug OCPBUGS-78485 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details.

Full error message. request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":[],"errors":{"rankBeforeIssue":"expected Object","rankAfterIssue":"expected Object"}}

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.
/retitle [release-4.20] : run resource request/limit check early

Details

In response to this:

This is an automated cherry-pick of #30879

/assign sdodson

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 987869f8-3d5e-4201-8bf9-a6cc0d682869

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-78485: run resource request/limit check early [release-4.20] : run resource request/limit check early Mar 17, 2026
@openshift-ci openshift-ci bot requested review from bparees and deads2k March 17, 2026 03:47
@sdodson sdodson added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Mar 17, 2026
@sdodson
Copy link
Member

sdodson commented Mar 17, 2026

/verified by CI

@sdodson
Copy link
Member

sdodson commented Mar 17, 2026

/retest-required

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 17, 2026
@openshift-ci-robot
Copy link

@sdodson: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Add [Early] to the "should set requests but not limits" test so it
runs in the early test bucket before the main parallel test suites.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Mar 17, 2026
@sdodson
Copy link
Member

sdodson commented Mar 17, 2026

/lgtm

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026
@sdodson
Copy link
Member

sdodson commented Mar 17, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Mar 17, 2026

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 17, 2026
@openshift-ci-robot
Copy link

@sdodson: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member

sdodson commented Mar 17, 2026

/override ci/prow/e2e-gcp-ovn ci/prow/e2e-gcp-ovn-upgrade ci/prow/e2e-metal-ipi-ovn-ipv6 ci/prow/e2e-vsphere-ovn ci/prow/e2e-vsphere-ovn-upi ci/prow/e2e-aws-ovn-fips

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-vsphere-ovn, ci/prow/e2e-vsphere-ovn-upi

Details

In response to this:

/override ci/prow/e2e-gcp-ovn ci/prow/e2e-gcp-ovn-upgrade ci/prow/e2e-metal-ipi-ovn-ipv6 ci/prow/e2e-vsphere-ovn ci/prow/e2e-vsphere-ovn-upi ci/prow/e2e-aws-ovn-fips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdodson
Copy link
Member

sdodson commented Mar 18, 2026

/override ci/prow/e2e-gcp-ovn ci/prow/e2e-gcp-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp-ovn ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-upgrade d5d4e0b link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-ovn d5d4e0b link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdodson sdodson added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 18, 2026
@sdodson sdodson merged commit 43070aa into openshift:release-4.20 Mar 18, 2026
15 of 17 checks passed
@openshift-cherrypick-robot
Copy link
Author

@openshift-cherrypick-robot: new pull request created: #30898

Details

In response to this:

This is an automated cherry-pick of #30879

/assign sdodson

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.