Skip to content

[release-4.19] : run resource request/limit check early#30898

Merged
sdodson merged 2 commits intoopenshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-30888-to-release-4.19
Mar 18, 2026
Merged

[release-4.19] : run resource request/limit check early#30898
sdodson merged 2 commits intoopenshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-30888-to-release-4.19

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Mar 18, 2026

This is an automated cherry-pick of #30888

/assign openshift-cherrypick-robot

sdodson and others added 2 commits March 18, 2026 02:13
@sdodson @claude
OCPBUGS-78485: run resource request/limit check early
ffb71c9 
Add [Early] to the "should set requests but not limits" test so it
runs in the early test bucket before the main parallel test suites.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sdodson @claude
OCPBUGS-78485: run resource request/limit check early
5518828 
Add [Early] to the "should set requests but not limits" test so it
runs in the early test bucket before the main parallel test suites.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 18, 2026
Merged
@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 44343157-4ceb-4f3d-8f6d-c6dacf9a5715

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from deads2k and sdodson March 18, 2026 02:14
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 5518828 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn 5518828 link true /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdodson sdodson added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 18, 2026
@sdodson
Copy link
Member

sdodson commented Mar 18, 2026

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 18, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2026

@sdodson: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson sdodson merged commit d7514f0 into openshift:release-4.19 Mar 18, 2026
15 of 18 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@dgoodwin dgoodwin

@adambkaplan adambkaplan

@kasturinarra kasturinarra

@Moebasim Moebasim

@openshift-cherrypick-robot openshift-cherrypick-robot

@jadhaj jadhaj

@lyman9966 lyman9966

@pamoedom pamoedom

@gangwgr gangwgr

@prabhapa prabhapa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.