feat: redesign OpenTDF.io homepage and update documentation styling#191
feat: redesign OpenTDF.io homepage and update documentation styling#191
Conversation
Summary of ChangesHello @vmorps, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience and visual appeal of the OpenTDF.io website by introducing a modern, redesigned homepage and updating the overall documentation styling. The changes aim to provide clearer messaging, better highlight key features, and offer improved navigation for developers and community members, making it easier to understand and engage with the OpenTDF project. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a major redesign of the OpenTDF.io homepage and new Java SDK code samples for encryption and decryption. A security audit identified several high-severity vulnerabilities in the Java code samples, specifically hardcoded secrets and insecure data handling. Additionally, the Java examples contain a compilation-preventing typo and resource leaks. These issues, even in documentation, pose a significant risk. It is strongly recommended to replace hardcoded credentials with a secure secret management solution, enforce secure TLS connections, correct the typo, and resolve resource leaks to adhere to best practices.
|
Java sample files have been removed from the branch; they had nothing to do with my PR. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a complete redesign of the OpenTDF.io homepage, replacing the old content with a modern, visually appealing design and updated messaging. It adds several new landing page sections (Hero, Problem/Solution, Developer First, Standards, Community, and Final CTA) as React components. The documentation's CSS has also been updated to align with the new design system, including new color schemes, navbar styling, and footer design.
The new components are well-structured, and the styling makes good use of modern CSS features like custom properties, color-mix, and animations. The changes significantly improve the look and feel of the site.
I've added a couple of suggestions to improve the new CSS for the navbar, focusing on layout robustness and maintainability. Overall, this is a fantastic update.
| .navbar__inner { | ||
| position: relative; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .navbar .navbar__brand { | ||
| color: var(--vds-color-blue-006); | ||
| font-size: 1.5rem; | ||
| position: absolute; | ||
| left: var(--ifm-navbar-padding-horizontal); | ||
| top: 50%; | ||
| transform: translateY(-50%); | ||
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
|
||
| /* Left items container: shrink-to-fit so parent can center it */ | ||
| .navbar__inner > .navbar__items:not(.navbar__items--right) { | ||
| flex: 0 0 auto; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| .navbar .navbar__items--right { | ||
| position: absolute; | ||
| right: var(--ifm-navbar-padding-horizontal); | ||
| top: 50%; | ||
| transform: translateY(-50%); | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 0.5rem; | ||
| } |
There was a problem hiding this comment.
The current implementation for the navbar layout using position: absolute for the brand and right-aligned items is a clever workaround for Docusaurus's DOM structure, but it can be fragile. On some viewport widths, the centered navigation links might grow to overlap with the absolutely positioned elements, causing layout issues or making them unclickable.
Please test this across various screen sizes, especially those just above the mobile breakpoint, to ensure the navigation remains usable and robust against content changes.
docusaurus.config.ts
Outdated
| logo: { | ||
| alt: "OpenTDF - Protect the Data, Build the Future", | ||
| src: "img/OpenTDF-Logo.png", | ||
| src: "img/opentdf-icon.svg", |
There was a problem hiding this comment.
| src: "img/opentdf-icon.svg", | |
| src: "img/OpenTDF-Logo.png", |
|
We also seem to have lost the light / dark switch functionality that is currently implemented in opentdf.io. We should fix that since it is used throughout the docs site. |
- Revert favicon and navbar logo to OpenTDF-Logo.png per reviewer suggestion - Add srcDark logo (OpenTDF-Logo-White.png) for dark mode navbar - Remove orphaned favicon.svg and opentdf-icon.svg assets - Restore light/dark mode toggle: make navbar theme-aware (was always-dark) - Fix navbar layout robustness: max-width prevents center links overlapping brand - Deduplicate GitHub icon SVG into --github-icon-svg CSS custom property - Normalize dark mode selectors to html[data-theme='dark'] throughout - Add light mode support to landing page homepage (sections, cards, text, buttons) - Fix tip admonition: amber readable in both modes; decouple note from amber rule - Fix footer: add theme-aware light mode styling - Add html[data-theme='light'] design token overrides for landing page tokens Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
## Summary - Add \`scripts/update-openapi-index.ts\` post-processing script that runs after \`docusaurus gen-api-docs\` to: - Rename \`.info.mdx\` files to \`index.mdx\` (prevents duplicate sidebar entries) - Regenerate \`docs/OpenAPI-clients/index.md\` with correct directory-based links - Chain post-processing automatically via \`gen-api-docs-all\` npm script - Refactor \`preprocessing.ts\`: extract shared \`SERVICE_DESCRIPTIONS\` and \`CATEGORY_MAPPING\` constants, add catch-all category for uncategorized APIs - Extend \`check-vendored-yaml\` to detect unregistered spec files in the platform repo — walks \`docs/openapi/\` via the GitHub Contents API and fails the build if a new API spec exists upstream without a corresponding entry in \`openApiSpecsArray\` - Add footer license info distinguishing Docs (CC BY 4.0) from Code (BSD 3-Clause) - Add \`gray-matter\` dependency for frontmatter parsing ## Preview 🔗 **https://opentdf-docs-preview-openapi-processing.surge.sh** ### Before vs After | | Before (Production) | After (Preview) | |---|---|---| | OpenAPI Clients Index | [/OpenAPI-clients](https://opentdf.io/OpenAPI-clients) | [/OpenAPI-clients](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients) | ### Preview — API Endpoint Root Pages These root pages previously did not resolve. This PR fixes them. | Service | Preview Link | |---|---| | Well-Known Configuration | [/OpenAPI-clients/wellknownconfiguration](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/wellknownconfiguration) | | KAS | [/OpenAPI-clients/kas](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/kas) | | V1 Authorization | [/OpenAPI-clients/authorization/v1](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/authorization/v1) | | V2 Authorization | [/OpenAPI-clients/authorization/v2](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/authorization/v2) | | V1 Entity Resolution | [/OpenAPI-clients/entityresolution/v1](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/entityresolution/v1) | | V2 Entity Resolution | [/OpenAPI-clients/entityresolution/v2](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/entityresolution/v2) | | Policy Objects | [/OpenAPI-clients/policy](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy) | | Policy Attributes | [/OpenAPI-clients/policy/attributes](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/attributes) | | Policy Namespaces | [/OpenAPI-clients/policy/namespaces](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/namespaces) | | Policy Actions | [/OpenAPI-clients/policy/actions](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/actions) | | Policy Subject Mapping | [/OpenAPI-clients/policy/subjectmapping](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/subjectmapping) | | Policy Resource Mapping | [/OpenAPI-clients/policy/resourcemapping](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/resourcemapping) | | Policy Obligations | [/OpenAPI-clients/policy/obligations](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/obligations) | | Policy Registered Resources | [/OpenAPI-clients/policy/registeredresources](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/registeredresources) | | Policy KAS Registry | [/OpenAPI-clients/policy/kasregistry](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/kasregistry) | | Key Management | [/OpenAPI-clients/policy/keymanagement](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/keymanagement) | | Policy Unsafe Service | [/OpenAPI-clients/policy/unsafe](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/unsafe) | ## Related - Homepage redesign: #191 - License update: #187 (merged) ## Test plan - [ ] Run \`npm run gen-api-docs-all\` and verify no build warnings about missing \`.info.mdx\` files - [ ] Verify \`docs/OpenAPI-clients/index.md\` links resolve correctly - [ ] Run \`npm run build\` and confirm no broken link errors on \`/OpenAPI-clients\` - [ ] Verify \`check-vendored-yaml\` fails if a new spec with API paths exists in the platform repo but is not registered in \`openApiSpecsArray\` 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
## Summary Addresses all review comments raised on #191. Includes a light mode pass across the entire site since the theme toggle was broken. ## Changes ### Reviewer-requested fixes (jp-ayyappan) - **Favicon**: reverted from `favicon.svg` back to `OpenTDF-Logo.png` - **Navbar logo**: reverted from `opentdf-icon.svg` back to `OpenTDF-Logo.png`; added `srcDark: "img/OpenTDF-Logo-White.png"` for automatic dark/light logo switching via Docusaurus's built-in `srcDark` config - **Light/dark mode toggle restored**: navbar was hardcoded always-dark, breaking the color mode switch; made fully theme-aware ### CSS improvements (gemini-code-assist) - **Navbar layout robustness**: added `max-width` guard on the centered nav links container to prevent overlap with the absolutely-positioned brand and right items at narrow viewports - **GitHub icon deduplication**: extracted the large SVG data URL into a `--github-icon-svg` CSS custom property; both `-webkit-mask-image` and `mask-image` now reference the variable ### Code hygiene - **Removed orphaned assets**: `favicon.svg` and `opentdf-icon.svg` were added by #191 and are now unreferenced — deleted - **Added** `static/img/OpenTDF-Logo-White.png` for dark mode navbar logo - **Normalized dark mode selectors**: new `[data-theme='dark']` rules aligned to `html[data-theme='dark']` to match the file's existing convention and specificity ### Light mode for the full site - **Navbar**: light glass background in light mode; dark glass in dark mode — with adaptive text, nav links, and GitHub button colors - **Footer**: was always-dark; now theme-aware with light gray background, dark text, and adapted link colors in light mode - **Landing page homepage**: all six sections (`Hero`, `ProblemSolution`, `DeveloperFirst`, `Standards`, `Community`, `FinalCTA`) now adapt to light mode — white/off-white section backgrounds, dark text, corrected button borders. Code windows (Hero) and TDF diagram (Standards) intentionally remain dark in both modes. - **Design tokens**: added `html[data-theme='light']` overrides for all `--otdf-*` CSS custom properties ### Admonition fixes - **`:::tip` dark mode**: was unreadable (cream background + white inherited text in dark mode); now uses a dark amber background (`#451a03`) with light amber text in dark mode - **`:::note` decoupled from amber**: the original rule incorrectly targeted `alert--secondary` (note) alongside tip — removed; notes now use Docusaurus's default dark-mode-safe secondary styling ## Preview 🔗 <a href="https://opentdf-docs-preview-191-review.surge.sh/" target="_blank">https://opentdf-docs-preview-191-review.surge.sh/</a> ## Test plan - [ ] Verify homepage renders correctly in both light and dark mode - [ ] Verify navbar logo switches between color and white versions on theme toggle - [ ] Verify color mode toggle is visible and functional in the navbar - [ ] Verify footer adapts to light/dark mode - [ ] Verify `:::tip` admonitions are readable in both modes on a docs page (e.g. `/quickstart`) - [ ] Verify `:::note` admonitions render with default gray styling (not amber) - [ ] Check navbar layout at various viewport widths above the mobile breakpoint 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
## Summary Addresses all review comments raised on #191. Includes a light mode pass across the entire site since the theme toggle was broken. ## Changes ### Reviewer-requested fixes (jp-ayyappan) - **Favicon**: reverted from `favicon.svg` back to `OpenTDF-Logo.png` - **Navbar logo**: reverted from `opentdf-icon.svg` back to `OpenTDF-Logo.png`; added `srcDark: "img/OpenTDF-Logo-White.png"` for automatic dark/light logo switching via Docusaurus's built-in `srcDark` config - **Light/dark mode toggle restored**: navbar was hardcoded always-dark, breaking the color mode switch; made fully theme-aware ### CSS improvements (gemini-code-assist) - **Navbar layout robustness**: added `max-width` guard on the centered nav links container to prevent overlap with the absolutely-positioned brand and right items at narrow viewports - **GitHub icon deduplication**: extracted the large SVG data URL into a `--github-icon-svg` CSS custom property; both `-webkit-mask-image` and `mask-image` now reference the variable ### Code hygiene - **Removed orphaned assets**: `favicon.svg` and `opentdf-icon.svg` were added by #191 and are now unreferenced — deleted - **Added** `static/img/OpenTDF-Logo-White.png` for dark mode navbar logo - **Normalized dark mode selectors**: new `[data-theme='dark']` rules aligned to `html[data-theme='dark']` to match the file's existing convention and specificity ### Light mode for the full site - **Navbar**: light glass background in light mode; dark glass in dark mode — with adaptive text, nav links, and GitHub button colors - **Footer**: was always-dark; now theme-aware with light gray background, dark text, and adapted link colors in light mode - **Landing page homepage**: all six sections (`Hero`, `ProblemSolution`, `DeveloperFirst`, `Standards`, `Community`, `FinalCTA`) now adapt to light mode — white/off-white section backgrounds, dark text, corrected button borders. Code windows (Hero) and TDF diagram (Standards) intentionally remain dark in both modes. - **Design tokens**: added `html[data-theme='light']` overrides for all `--otdf-*` CSS custom properties ### Admonition fixes - **`:::tip` dark mode**: was unreadable (cream background + white inherited text in dark mode); now uses a dark amber background (`#451a03`) with light amber text in dark mode - **`:::note` decoupled from amber**: the original rule incorrectly targeted `alert--secondary` (note) alongside tip — removed; notes now use Docusaurus's default dark-mode-safe secondary styling ## Preview 🔗 <a href="https://opentdf-docs-preview-191-review.surge.sh/" target="_blank">https://opentdf-docs-preview-191-review.surge.sh/</a> ## Test plan - [ ] Verify homepage renders correctly in both light and dark mode - [ ] Verify navbar logo switches between color and white versions on theme toggle - [ ] Verify color mode toggle is visible and functional in the navbar - [ ] Verify footer adapts to light/dark mode - [ ] Verify `:::tip` admonitions are readable in both modes on a docs page (e.g. `/quickstart`) - [ ] Verify `:::note` admonitions render with default gray styling (not amber) - [ ] Check navbar layout at various viewport widths above the mobile breakpoint 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
- Add \`scripts/update-openapi-index.ts\` post-processing script that runs after \`docusaurus gen-api-docs\` to: - Rename \`.info.mdx\` files to \`index.mdx\` (prevents duplicate sidebar entries) - Regenerate \`docs/OpenAPI-clients/index.md\` with correct directory-based links - Chain post-processing automatically via \`gen-api-docs-all\` npm script - Refactor \`preprocessing.ts\`: extract shared \`SERVICE_DESCRIPTIONS\` and \`CATEGORY_MAPPING\` constants, add catch-all category for uncategorized APIs - Extend \`check-vendored-yaml\` to detect unregistered spec files in the platform repo — walks \`docs/openapi/\` via the GitHub Contents API and fails the build if a new API spec exists upstream without a corresponding entry in \`openApiSpecsArray\` - Add footer license info distinguishing Docs (CC BY 4.0) from Code (BSD 3-Clause) - Add \`gray-matter\` dependency for frontmatter parsing 🔗 **https://opentdf-docs-preview-openapi-processing.surge.sh** | | Before (Production) | After (Preview) | |---|---|---| | OpenAPI Clients Index | [/OpenAPI-clients](https://opentdf.io/OpenAPI-clients) | [/OpenAPI-clients](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients) | These root pages previously did not resolve. This PR fixes them. | Service | Preview Link | |---|---| | Well-Known Configuration | [/OpenAPI-clients/wellknownconfiguration](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/wellknownconfiguration) | | KAS | [/OpenAPI-clients/kas](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/kas) | | V1 Authorization | [/OpenAPI-clients/authorization/v1](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/authorization/v1) | | V2 Authorization | [/OpenAPI-clients/authorization/v2](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/authorization/v2) | | V1 Entity Resolution | [/OpenAPI-clients/entityresolution/v1](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/entityresolution/v1) | | V2 Entity Resolution | [/OpenAPI-clients/entityresolution/v2](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/entityresolution/v2) | | Policy Objects | [/OpenAPI-clients/policy](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy) | | Policy Attributes | [/OpenAPI-clients/policy/attributes](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/attributes) | | Policy Namespaces | [/OpenAPI-clients/policy/namespaces](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/namespaces) | | Policy Actions | [/OpenAPI-clients/policy/actions](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/actions) | | Policy Subject Mapping | [/OpenAPI-clients/policy/subjectmapping](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/subjectmapping) | | Policy Resource Mapping | [/OpenAPI-clients/policy/resourcemapping](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/resourcemapping) | | Policy Obligations | [/OpenAPI-clients/policy/obligations](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/obligations) | | Policy Registered Resources | [/OpenAPI-clients/policy/registeredresources](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/registeredresources) | | Policy KAS Registry | [/OpenAPI-clients/policy/kasregistry](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/kasregistry) | | Key Management | [/OpenAPI-clients/policy/keymanagement](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/keymanagement) | | Policy Unsafe Service | [/OpenAPI-clients/policy/unsafe](https://opentdf-docs-preview-openapi-processing.surge.sh/OpenAPI-clients/policy/unsafe) | - Homepage redesign: #191 - License update: #187 (merged) - [ ] Run \`npm run gen-api-docs-all\` and verify no build warnings about missing \`.info.mdx\` files - [ ] Verify \`docs/OpenAPI-clients/index.md\` links resolve correctly - [ ] Run \`npm run build\` and confirm no broken link errors on \`/OpenAPI-clients\` - [ ] Verify \`check-vendored-yaml\` fails if a new spec with API paths exists in the platform repo but is not registered in \`openApiSpecsArray\` 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
Redesigned the OpenTDF.io homepage with new messaging and contemporary design, including new landing page components (Hero, ProblemSolution, DeveloperFirst, Standards, Community, FinalCTA). Updated documentation CSS to reflect the new design. Adds new favicon and OpenTDF icon, and includes Java SDK encrypt/decrypt collection code samples. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
…separately) Signed-off-by: Mike Morper <mike.morper@virtru.com>
- Replace opentdf-social.png with new dark-themed brand-compliant 1200x630 image featuring gradient headline, code window, opentdf.io URL, license text, and TDF/services pills - Add complete og:type, og:site_name, og:url, og:image:width/height tags - Add Twitter/X Card meta tags to homepage - Fix Schema.org JSON-LD logo URL to opentdf.io Closes #192 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
Local Claude instructions should never be pushed to the remote. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
Remove navbar logo image entirely — "OpenTDF" text wordmark only. Revert favicon back to OpenTDF-Logo.png pending icon direction decision. Retains favicon.svg and opentdf-icon.svg on disk for PR #196 to clean up. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
Move og-concepts.html, og-export.html, and brand-guide.html into design/ subfolder. Update .gitignore to ignore design/ as a single rule instead of individual file entries. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
## Summary Addresses all review comments raised on #191. Includes a light mode pass across the entire site since the theme toggle was broken. ## Changes ### Reviewer-requested fixes (jp-ayyappan) - **Favicon**: reverted from `favicon.svg` back to `OpenTDF-Logo.png` - **Navbar logo**: reverted from `opentdf-icon.svg` back to `OpenTDF-Logo.png`; added `srcDark: "img/OpenTDF-Logo-White.png"` for automatic dark/light logo switching via Docusaurus's built-in `srcDark` config - **Light/dark mode toggle restored**: navbar was hardcoded always-dark, breaking the color mode switch; made fully theme-aware ### CSS improvements (gemini-code-assist) - **Navbar layout robustness**: added `max-width` guard on the centered nav links container to prevent overlap with the absolutely-positioned brand and right items at narrow viewports - **GitHub icon deduplication**: extracted the large SVG data URL into a `--github-icon-svg` CSS custom property; both `-webkit-mask-image` and `mask-image` now reference the variable ### Code hygiene - **Removed orphaned assets**: `favicon.svg` and `opentdf-icon.svg` were added by #191 and are now unreferenced — deleted - **Added** `static/img/OpenTDF-Logo-White.png` for dark mode navbar logo - **Normalized dark mode selectors**: new `[data-theme='dark']` rules aligned to `html[data-theme='dark']` to match the file's existing convention and specificity ### Light mode for the full site - **Navbar**: light glass background in light mode; dark glass in dark mode — with adaptive text, nav links, and GitHub button colors - **Footer**: was always-dark; now theme-aware with light gray background, dark text, and adapted link colors in light mode - **Landing page homepage**: all six sections (`Hero`, `ProblemSolution`, `DeveloperFirst`, `Standards`, `Community`, `FinalCTA`) now adapt to light mode — white/off-white section backgrounds, dark text, corrected button borders. Code windows (Hero) and TDF diagram (Standards) intentionally remain dark in both modes. - **Design tokens**: added `html[data-theme='light']` overrides for all `--otdf-*` CSS custom properties ### Admonition fixes - **`:::tip` dark mode**: was unreadable (cream background + white inherited text in dark mode); now uses a dark amber background (`#451a03`) with light amber text in dark mode - **`:::note` decoupled from amber**: the original rule incorrectly targeted `alert--secondary` (note) alongside tip — removed; notes now use Docusaurus's default dark-mode-safe secondary styling ## Preview 🔗 <a href="https://opentdf-docs-preview-191-review.surge.sh/" target="_blank">https://opentdf-docs-preview-191-review.surge.sh/</a> ## Test plan - [ ] Verify homepage renders correctly in both light and dark mode - [ ] Verify navbar logo switches between color and white versions on theme toggle - [ ] Verify color mode toggle is visible and functional in the navbar - [ ] Verify footer adapts to light/dark mode - [ ] Verify `:::tip` admonitions are readable in both modes on a docs page (e.g. `/quickstart`) - [ ] Verify `:::note` admonitions render with default gray styling (not amber) - [ ] Check navbar layout at various viewport widths above the mobile breakpoint 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
- Fix npm build by removing duplicate *.info.mdx files generated by docusaurus-plugin-openapi-docs v4.7.1; the plugin now generates both index.mdx and *.info.mdx with identical IDs, breaking Docusaurus's category index association and causing useCurrentSidebarCategory() errors during SSG - Bump docusaurus-plugin-openapi-docs and docusaurus-theme-openapi-docs to 4.7.1 to match package.json constraint - Replace brew install CLI card with a link to the latest otdfctl release Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
Re-adds the cyan diamond favicon SVG and updates docusaurus.config.ts to reference it; the PNG was a temporary stand-in pending a new brand mark from marketing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
fbf20c5 to
bb0eff5
Compare
Lock file was out of sync after rebase conflict resolution, causing npm ci to fail in CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
Conflict markers from a prior merge were baked into the commit history, causing a parse error during build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mike Morper <mike.morper@virtru.com>
|
tagging in @cassandrabailey293 for architecture awareness and review |
jrschumacher
left a comment
There was a problem hiding this comment.
Blocking this PR. There is a relevant meeting next week and @cassandrabailey293 will reach out after.
Preview
opentdf-docs-preview-new-home.surge.sh
Summary
Additional changes (post-review)
favicon.svg(cyan diamond mark); a new brand mark for OpenTDF as an independent project is in progress and will be swapped in via a follow-up PRopentdf-icon.svg) — replaced by the aboveHero,ProblemSolution,DeveloperFirst,Standards,Community,FinalCTA) now adapt to light mode; code windows and diagrams intentionally stay dark:::notefrom amber styling; added proper dark amber for:::tiponly)brew install opentdf/tap/otdfctlwith a link to the latest otdfctl release— updated
docusaurus-plugin-openapi-docsto4.7.1(was installed at4.4.0against a^4.7.1requirement); fixed post-processing script to remove duplicate*.info.mdxfiles the updated plugin now generates alongsideindex.mdx, which were breakinguseCurrentSidebarCategory()during SSGTest plan
npm run buildcompletes with zero errors🤖 Generated with Claude Code