Skip to content

feat(file): add 400 response handling for file get/delete#37

Merged
retr0h merged 1 commit intomainfrom
fix/file-400-responses
Mar 6, 2026
Merged

feat(file): add 400 response handling for file get/delete#37
retr0h merged 1 commit intomainfrom
fix/file-400-responses

Conversation

@retr0h
Copy link
Collaborator

@retr0h retr0h commented Mar 6, 2026

Summary

  • Add 400 (BadRequest) response handling for file get and delete endpoints
  • Update generated API spec and client code with new response types
  • Add test coverage for 400 response paths

Test plan

  • Unit tests for 400 response handling on file get/delete
  • All tests pass (just go::unit)

🤖 Generated with Claude Code

Wire JSON400 error responses into checkError for Get and Delete
methods so validation errors (e.g., invalid file names) surface as
typed ValidationError to callers.

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Thank you for contributing to this project! 😊🕹️

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1653      1655    +2     
=========================================
+ Hits          1653      1655    +2     
Files with missing lines Coverage Δ
pkg/osapi/file.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee964e1...334f552. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@retr0h retr0h merged commit a4a9206 into main Mar 6, 2026
7 checks passed
@retr0h retr0h deleted the fix/file-400-responses branch March 6, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant