Skip to content

feat(file): add 400 response handling for file get/delete #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
retr0h merged 1 commit into from
Mar 6, 2026
Merged

feat(file): add 400 response handling for file get/delete #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
316 changes: 159 additions & 157 deletions docs/gen/gen.md
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/gen/osapi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ type FileService struct {
```

<a name="FileService.Delete"></a>
### func \(\*FileService\) [Delete](<https://github.com/osapi-io/osapi-sdk/blob/main/pkg/osapi/file.go#L130-L133>)
### func \(\*FileService\) [Delete](<https://github.com/osapi-io/osapi-sdk/blob/main/pkg/osapi/file.go#L131-L134>)

```go
func (s *FileService) Delete(ctx context.Context, name string) (*Response[FileDelete], error)
Expand Down
2 changes: 2 additions & 0 deletions pkg/osapi/file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ func (s *FileService) Get(

if err := checkError(
resp.StatusCode(),
resp.JSON400,
resp.JSON401,
resp.JSON403,
resp.JSON404,
Expand Down Expand Up @@ -138,6 +139,7 @@ func (s *FileService) Delete(

if err := checkError(
resp.StatusCode(),
resp.JSON400,
resp.JSON401,
resp.JSON403,
resp.JSON404,
Expand Down
34 changes: 34 additions & 0 deletions pkg/osapi/file_public_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,23 @@ func (suite *FilePublicTestSuite) TestGet() {
suite.Equal(512, resp.Data.Size)
},
},
{
name: "when server returns 400 returns ValidationError",
fileName: "nginx.conf",
handler: func(w http.ResponseWriter, _ *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusBadRequest)
_, _ = w.Write([]byte(`{"error":"invalid file name"}`))
},
validateFunc: func(resp *osapi.Response[osapi.FileMetadata], err error) {
suite.Error(err)
suite.Nil(resp)

var target *osapi.ValidationError
suite.True(errors.As(err, &target))
suite.Equal(http.StatusBadRequest, target.StatusCode)
},
},
{
name: "when server returns 404 returns NotFoundError",
fileName: "missing.conf",
Expand Down Expand Up @@ -393,6 +410,23 @@ func (suite *FilePublicTestSuite) TestDelete() {
suite.True(resp.Data.Deleted)
},
},
{
name: "when server returns 400 returns ValidationError",
fileName: "old.conf",
handler: func(w http.ResponseWriter, _ *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusBadRequest)
_, _ = w.Write([]byte(`{"error":"invalid file name"}`))
},
validateFunc: func(resp *osapi.Response[osapi.FileDelete], err error) {
suite.Error(err)
suite.Nil(resp)

var target *osapi.ValidationError
suite.True(errors.As(err, &target))
suite.Equal(http.StatusBadRequest, target.StatusCode)
},
},
{
name: "when server returns 404 returns NotFoundError",
fileName: "missing.conf",
Expand Down
Loading