AO3-7285 Adding User ID to header for Works and Creations page#5586
AO3-7285 Adding User ID to header for Works and Creations page#55860ce10tsgit wants to merge 3 commits intootwcode:masterfrom
Conversation
Pass user ID to page_heading translation in creations.html.erb and
update en.yml to display "Works and Comments by %{user} (%{id})".
0ce10tsgit
changed the title
Normalized because I lowkey forgot to
|
Hi, Oyon Ganguli (0ce10tsgit)! Thank you so much for this pull request. Someone will be along to review it soon. I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
There was a problem hiding this comment.
Please add an automated test. The easiest should be to modify the existing scenario in admin_manage_users to add an new step that checks for the user id (you'll have to make a new step for it so you can get the id from the user in the code to check for it, since it's not always the same between test runs). If this confusing please let me know and I'll explain more!
I added the cucumber step then wrote the defintion I used the invitation ID defintion as reference. For the cucumber I saw that for inviation ID it was only checked for one user not all users so I only added it in cucumber testing for checking "lurkers" admin page because theoretically if it is bugged it should be setoff for that test and not escape in the other.
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
|
Thanks for the feedack, im new to test driven development. |
Bilka2
left a comment
Bilka2
left a comment
There was a problem hiding this comment.
Your logic in the commit message is correct, so this looks good!
3 participants
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7285
Purpose
For the Works and Comments page (admin/users/specific_username/creations) added user id next to the header so it displays as "Works and Comments by user (id)" versus before were no user ID was shown and just "Works and Comments by user" for better clarification
Credit
Oyon Ganguli (0ce10tsgit) - He/Him
If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.
Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.