Skip to content

AO3-7285 Adding User ID to header for Works and Creations page #5586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bilka2 merged 3 commits into from
Mar 7, 2026
Merged

AO3-7285 Adding User ID to header for Works and Creations page #5586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e48f7bb
AO3-7285 Adding user id on creations page for admin
0ce10tsgit Feb 16, 2026
5f58601
AO3-7285 Normalize en.yml locale file
0ce10tsgit Feb 16, 2026
f34b325
AO3-7258 Added Automated Tests
0ce10tsgit Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/admin/admin_users/creations.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="admin">
<!--Descriptive page name, messages and instructions-->
<h2 class="heading"><%= t(".page_heading", user: @user.login) %></h2>
<h2 class="heading"><%= t(".page_heading", user: @user.login, id: @user.id) %></h2>
<!--/descriptions-->

<!--subnav-->
Expand Down
2 changes: 1 addition & 1 deletion config/locales/views/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ en:
admin_user: User Administration
creations: Creations
no_creations: This user has no works or comments.
page_heading: Works and Comments by %{user}
page_heading: Works and Comments by %{user} (%{id})
page_title: "%{login} - User Creations"
history:
heading: User History
Expand Down
1 change: 1 addition & 0 deletions features/admins/users/admin_manage_users.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ Feature: Admin Actions to manage users
And I go to the user administration page for "lurker"
And I follow "Creations"
Then I should see "Works and Comments by lurker"
And I should see the user id for "lurker" in the creations page heading
And I should see "This user has no works or comments."
And the page should have a dashboard sidebar
When I go to lurker's user page
Expand Down
5 changes: 5 additions & 0 deletions features/step_definitions/admin_steps.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,3 +609,8 @@
user_id = User.find_by(login: username).id
step %{I should see "#{action.capitalize} as Fannish Next of Kin for: #{user_id}" within "#user_history"}
end

Then "I should see the user id for {string} in the creations page heading" do |login|
user = User.find_by(login: login)
expect(page).to have_content("Works and Comments by #{login} (#{user.id})")
end
Loading