ci: update workflows (checkout v6, recursive submodules), mbedTLS v4 compatibility, Windows fix#3529
Conversation
.github/workflows/ci.yml
Outdated
| pull_request: | ||
|
|
||
| env: | ||
| LUA_VERSION: "5.4" |
There was a problem hiding this comment.
Please remove all hardcoded Lua versions from all workflow. Let the system to choose the right version. I think it's a good feedback if we need to align that in the code (and the build system).
There was a problem hiding this comment.
Note here, we already fixed the Lua version issue in #3525.
There was a problem hiding this comment.
Should the Lua version be selected dynamically by the system going forward, or do we want to keep a fixed version (at least for certain environments like Linux)?
There was a problem hiding this comment.
I think we should let the system to choose the right version. Usually, macOS uses the recent releases, which is good, because we can get notification about that.
If we use a fixed version, then we can forget to update the code.
There was a problem hiding this comment.
macOS now follows the previous behavior (using the default system setup), while Linux has been updated to dynamically detect and use the currently available Lua version.
This should give us more flexibility on Linux while keeping macOS stable and aligned with its typical environment.
Updated CI workflow to dynamically detect and install the latest Lua development package instead of using a fixed version.
|
2 participants
what
ci_new.ymlfrom PR fix(ci): pin Lua version on 5.4 #3524ci.ymland aligned it with the new workflow structureactions/checkoutfrom v4 to v6submodules: truetorecursivewhy
ci.ymlwas not fully compatible with these updatesactions/checkout@v6is the newer and recommended versionrecursiveensures all submodules are properly fetchedreferences