Skip to content

Allow humility stackmargin to take task names as arguments#604

Merged
mkeeter merged 1 commit intomasterfrom
mkeeter/per-task-stackmargin
Mar 11, 2026
Merged

Allow humility stackmargin to take task names as arguments#604
mkeeter merged 1 commit intomasterfrom
mkeeter/per-task-stackmargin

Conversation

@mkeeter
Copy link
Contributor

@mkeeter mkeeter commented Mar 10, 2026

When testing oxidecomputer/hubris#2428, I ran humility stackmargin thermal and was sad that it didn't work.

fn task_name_suggestion(&self, name: &str) -> anyhow::Error {
// Suggest only for very small differences
// High number can result in inaccurate suggestions for short queries e.g. `rls`
const MAX_DISTANCE: usize = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I like this idea

@mkeeter mkeeter force-pushed the mkeeter/per-task-stackmargin branch from 53afeda to 5e9d177 Compare March 11, 2026 18:40
@mkeeter mkeeter enabled auto-merge (squash) March 11, 2026 18:41
@mkeeter mkeeter merged commit f0d4307 into master Mar 11, 2026
12 checks passed
@mkeeter mkeeter deleted the mkeeter/per-task-stackmargin branch March 11, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants