Conversation
|
Also important note, this update created before music update |
|
there are too many changes and things that went backwards on this PR, I would prefer to keep the previous one and work from it, it will be less work and headache for me. (let's keep this one open to be able to help me reporting the required changes on the other one) |
petitlapin
force-pushed
the
newttf
branch
2 times, most recently
from
adae9e3 to
090410c
Compare
petitlapin
force-pushed
the
newttf
branch
2 times, most recently
from
c26433c to
5ec4e92
Compare
… limit name size to 16 characters
petitlapin
left a comment
petitlapin
left a comment
There was a problem hiding this comment.
I managed to find the time to review it :). There are still things to update but it's going in the correct direction.
| DrawText(740, 340, T_lives, Sprites[fgame].Image[0]); | ||
| m_screen.ChangeFontSize(20); | ||
| m_screen.ChangeFontColor(255, 255, 0); | ||
| m_screen.PrintText("Level", 740 - m_screen.TextLength("Level") / 2, 110); |
There was a problem hiding this comment.
we should avoid to have to repeat the text in all of the PrintText calls. I would suggest to add a enum parameter to the function: TextAlignment with 2 possible values AlignLeft and AlignCenter. If AlignLeft is set we don't do anything, if AlignCenter is set we compute the shift inside the PrintText method
| SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "Unable to initialize SDL: %s", SDL_GetError()); | ||
| exit(-1); | ||
| } | ||
| TTF_Init(); |
There was a problem hiding this comment.
we should probably call TTF_Quit at the end but for now it segfaults (probably because we call it before the destructor of Screen is called)
| // When paused, asks for a key press | ||
| if (Pause) { | ||
| m_screen.PrintText(T_press_any_key, LT * D_Case / 2, 300); | ||
| m_screen.ChangeFontSize(60); |
There was a problem hiding this comment.
I like this shadowing. I think it can potentially be used in other places so it would be better to have a method PrintShadowedText in Screen that will call internally twice the PrintText method: one for the black shadow text and one for the text with the wanted color
|
|
||
| // *** Loads the languages file *** | ||
| // ******************************** | ||
| if (Utils::FileExists(PathFile) == false) { |
There was a problem hiding this comment.
it would be nice to display the different languages in the selection menu with texts instead of images, can you update it to use texts? Don't bother translating, you can use these texts representing the languages for now, I will fix them later:
"de_DE", "en_US", "es_ES", "fr_FR", "ar_AR", "zh_CN", "ja_JP", "ru_RU", "sl_SI", "it_IT", "br_FR", "pt_PT", "sv_SV", "eo", "hu_HU", "tr_TR", "pl_PL", "nl_NL", "ko_KR"
|
https://github.com/zabidenhtf/Li-RiTransofrmedImagesIntoText And also, i started to transform images translations into text. |
|
And I almost finished Ukrainian translation |
2 participants
Yep, this is another version of my ttf system