Replace internal sniffs with PHPCSExtra Universal equivalents#55
Merged
dereuromark merged 1 commit intomasterfrom Apr 10, 2026
Merged
Replace internal sniffs with PHPCSExtra Universal equivalents#55dereuromark merged 1 commit intomasterfrom
dereuromark merged 1 commit intomasterfrom
Conversation
Drop two internal sniffs in favor of their Universal counterparts which are strict supersets: - PhpCollective.ControlStructures.DisallowAlternativeControlStructures -> Universal.ControlStructures.DisallowAlternativeSyntax - PhpCollective.WhiteSpace.CommaSpacing -> Universal.WhiteSpace.CommaSpacing Universal adds chained if/elseif/else fixing, optional inline-HTML allowance, trailing-comment handling, modular error codes and metrics. The trailing-comma-before-] behavior previously folded into our CommaSpacing sniff stays covered by DisallowTrailingCommaInSingleLine.
dereuromark
force-pushed
the
feature/replace-sniffs-with-universal
branch
from
00bea18 to
24d3164
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops two internal sniffs in favor of their PHPCSExtra Universal counterparts, which are strict supersets of our implementations.
PhpCollective.ControlStructures.DisallowAlternativeControlStructuresUniversal.ControlStructures.DisallowAlternativeSyntaxPhpCollective.WhiteSpace.CommaSpacingUniversal.WhiteSpace.CommaSpacingWhy Universal is a superset
DisallowAlternativeSyntax additionally provides:
if/elseif/elsefixed as a single unit (avoids fixer conflicts)else:→} else {replacementallowWithInlineHTMLfor template code (defaultfalse— matches our behavior)FoundIf,FoundFor, …)CommaSpacing additionally provides:
CommaAfterCommentfixer (moves the comma in front of trailing comments)InFunctionCall,InFunctionDeclaration,InClosureUse,InDeclare,InAttributeBlock)The one "extra" our internal
CommaSpacingSniffdid — stripping a trailing comma before]in single-line arrays — is already covered byPhpCollective.PHP.DisallowTrailingCommaInSingleLine, so no functionality is lost.Related to #53.
composer cs-check,composer test,composer stanandcomposer docsall pass locally.