Skip to content

Replace internal sniffs with PHPCSExtra Universal equivalents #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dereuromark merged 1 commit into from
Apr 10, 2026
Merged

Replace internal sniffs with PHPCSExtra Universal equivalents #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 0 additions & 75 deletions PhpCollective/Sniffs/ControlStructures/DisallowAlternativeControlStructuresSniff.php
View file
Open in desktop

This file was deleted.

122 changes: 0 additions & 122 deletions PhpCollective/Sniffs/WhiteSpace/CommaSpacingSniff.php
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions PhpCollective/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,8 @@
<rule ref="Universal.Constants.LowercaseClassResolutionKeyword"/>
<rule ref="Universal.Constants.UppercaseMagicConstants"/>
<rule ref="Universal.WhiteSpace.PrecisionAlignment"/>
<rule ref="Universal.WhiteSpace.CommaSpacing"/>
<rule ref="Universal.ControlStructures.DisallowAlternativeSyntax"/>
<rule ref="Universal.Operators.ConcatPosition"/>
<rule ref="Universal.Operators.TypeSeparatorSpacing"/>
<rule ref="Universal.UseStatements.NoUselessAliases"/>
Expand Down
8 changes: 4 additions & 4 deletions docs/sniffs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ PEAR (4 sniffs)
- PEAR.Functions.ValidDefaultValue
- PEAR.NamingConventions.ValidClassName

PhpCollective (87 sniffs)
PhpCollective (85 sniffs)
-------------------------
- PhpCollective.Arrays.ArrayBracketSpacing
- PhpCollective.Arrays.DisallowImplicitArrayCreation
Expand Down Expand Up @@ -97,7 +97,6 @@ PhpCollective (87 sniffs)
- PhpCollective.ControlStructures.ControlSignature
- PhpCollective.ControlStructures.ControlStructureEmptyStatement
- PhpCollective.ControlStructures.ControlStructureSpacing
- PhpCollective.ControlStructures.DisallowAlternativeControlStructures
- PhpCollective.ControlStructures.DisallowCloakingCheck
- PhpCollective.ControlStructures.ElseIfDeclaration
- PhpCollective.ControlStructures.NoInlineAssignment
Expand All @@ -123,7 +122,6 @@ PhpCollective (87 sniffs)
- PhpCollective.Testing.AssertPrimitives
- PhpCollective.Testing.ExpectException
- PhpCollective.Testing.Mock
- PhpCollective.WhiteSpace.CommaSpacing
- PhpCollective.WhiteSpace.ConcatenationSpacing
- PhpCollective.WhiteSpace.ConsistentIndent
- PhpCollective.WhiteSpace.DocBlockSpacing
Expand Down Expand Up @@ -270,17 +268,19 @@ Squiz (27 sniffs)
- Squiz.WhiteSpace.SemicolonSpacing
- Squiz.WhiteSpace.SuperfluousWhitespace

Universal (10 sniffs)
Universal (12 sniffs)
---------------------
- Universal.CodeAnalysis.ConstructorDestructorReturn
- Universal.CodeAnalysis.ForeachUniqueAssignment
- Universal.CodeAnalysis.NoEchoSprintf
- Universal.CodeAnalysis.StaticInFinalClass
- Universal.Constants.LowercaseClassResolutionKeyword
- Universal.Constants.UppercaseMagicConstants
- Universal.ControlStructures.DisallowAlternativeSyntax
- Universal.Operators.ConcatPosition
- Universal.Operators.TypeSeparatorSpacing
- Universal.UseStatements.NoUselessAliases
- Universal.WhiteSpace.CommaSpacing
- Universal.WhiteSpace.PrecisionAlignment

Zend (1 sniff)
Expand Down
30 changes: 0 additions & 30 deletions .../PhpCollective/Sniffs/ControlStructures/DisallowAlternativeControlStructuresSniffTest.php
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions tests/PhpCollective/Sniffs/WhiteSpace/CommaSpacingSniffTest.php
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions tests/_data/CommaSpacing/after.php
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions tests/_data/CommaSpacing/before.php
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions tests/_data/DisallowAlternativeControlStructures/after.php
View file
Open in desktop

This file was deleted.

Loading
Loading