Skip to content

🎨 Palette: Add tooltips to message input buttons #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinaboos wants to merge 1 commit into from
Closed

🎨 Palette: Add tooltips to message input buttons #744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 45 additions & 1 deletion src/room/room_input_bar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ use makepad_widgets::*;
use matrix_sdk::room::reply::{EnforceThread, Reply};
use matrix_sdk_ui::timeline::{EmbeddedEvent, EventTimelineItem, TimelineEventItemId};
use ruma::{events::room::message::{LocationMessageEventContent, MessageType, RoomMessageEventContent}, OwnedRoomId};
use crate::{home::{editing_pane::{EditingPaneState, EditingPaneWidgetExt}, location_preview::LocationPreviewWidgetExt, room_screen::{populate_preview_of_timeline_item, MessageAction, RoomScreenProps}, tombstone_footer::{SuccessorRoomDetails, TombstoneFooterWidgetExt}}, location::init_location_subscriber, shared::{avatar::AvatarWidgetRefExt, html_or_plaintext::HtmlOrPlaintextWidgetRefExt, mentionable_text_input::MentionableTextInputWidgetExt, popup_list::{enqueue_popup_notification, PopupKind}, styles::*}, sliding_sync::{submit_async_request, MatrixRequest, UserPowerLevels}, utils};
use crate::{home::{editing_pane::{EditingPaneState, EditingPaneWidgetExt}, location_preview::LocationPreviewWidgetExt, room_screen::{populate_preview_of_timeline_item, MessageAction, RoomScreenProps}, tombstone_footer::{SuccessorRoomDetails, TombstoneFooterWidgetExt}}, location::init_location_subscriber, shared::{avatar::AvatarWidgetRefExt, callout_tooltip::{CalloutTooltipOptions, TooltipAction, TooltipPosition}, html_or_plaintext::HtmlOrPlaintextWidgetRefExt, mentionable_text_input::MentionableTextInputWidgetExt, popup_list::{enqueue_popup_notification, PopupKind}, styles::*}, sliding_sync::{submit_async_request, MatrixRequest, UserPowerLevels}, utils};

live_design! {
use link::theme::*;
Expand Down Expand Up @@ -186,6 +186,50 @@ impl Widget for RoomInputBar {
.get::<RoomScreenProps>()
.expect("BUG: RoomScreenProps should be available in Scope::props for RoomInputBar");

match event.hits(cx, self.button(ids!(location_button)).area()) {
Hit::FingerHoverIn(hover) => {
cx.widget_action(
self.widget_uid(),
&scope.path,
TooltipAction::HoverIn {
text: "Share location".to_string(),
widget_rect: hover.rect,
options: CalloutTooltipOptions {
position: TooltipPosition::Top,
..Default::default()
},
},
);
}
Hit::FingerHoverOut(_) => {
cx.widget_action(self.widget_uid(), &scope.path, TooltipAction::HoverOut);
}
_ => {}
}

match event.hits(cx, self.button(ids!(send_message_button)).area()) {
Hit::FingerHoverIn(hover) => {
let text_is_empty = self.mentionable_text_input(ids!(mentionable_text_input)).text().trim().is_empty();
let tooltip_text = if text_is_empty { "Type a message to send" } else { "Send message" };
cx.widget_action(
self.widget_uid(),
&scope.path,
TooltipAction::HoverIn {
text: tooltip_text.to_string(),
widget_rect: hover.rect,
options: CalloutTooltipOptions {
position: TooltipPosition::Top,
..Default::default()
},
},
);
}
Hit::FingerHoverOut(_) => {
cx.widget_action(self.widget_uid(), &scope.path, TooltipAction::HoverOut);
}
_ => {}
}

match event.hits(cx, self.view.view(ids!(replying_preview.reply_preview_content)).area()) {
// If the hit occurred on the replying message preview, jump to it.
Hit::FingerUp(fe) if fe.is_over && fe.is_primary_hit() && fe.was_tap() => {
Expand Down