OM 2.0: Remove references to additional suffixes on samples#2875
Merged
dashpole merged 2 commits intoprometheus:mainfrom Mar 11, 2026
Merged
OM 2.0: Remove references to additional suffixes on samples#2875dashpole merged 2 commits intoprometheus:mainfrom
dashpole merged 2 commits intoprometheus:mainfrom
Conversation
Signed-off-by: David Ashpole <dashpole@google.com>
krajorama
previously approved these changes
Mar 11, 2026
Member
krajorama
left a comment
krajorama
left a comment
There was a problem hiding this comment.
Agree, we replaced the generic rule with SHOULD, so no point in this.
Signed-off-by: David Ashpole <dashpole@google.com>
Contributor
Author
|
The rebase removed approvals. I'm merging as the diff is still the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samples no longer have suffixes that extend the name of their metric family. Remove language that suggests they could have one.
cc @bwplotka @krajorama @ywwg