Conversation
SuperQ
reviewed
Feb 11, 2026
Member
|
This needs a DCO sign-off. You can use |
ananthb
force-pushed
the
bcachefs
branch
2 times, most recently
from
718e40a to
af22448
Compare
SuperQ
requested changes
Feb 23, 2026
ananthb
force-pushed
the
bcachefs
branch
2 times, most recently
from
594f69a to
27b2119
Compare
Member
|
This looks mostly fine. We tend to avoid buffio scanners and prefer |
Signed-off-by: Ananth Bhaskararaman <antsub@gmail.com>
SuperQ
approved these changes
Feb 24, 2026
Member
|
If you have any weight with upstream bcachefs, maybe worth getting them to make some slightly more machine friendly proc files. Having to parse K/M/G/etc is a lot of extra work. |
Contributor
Author
|
I don't hold sway there but I expected raw values too. It is weird. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for parsing bcachefs filesystems from procfs.