apache::params: Use correct PHP version on Ubuntu 24.04#2575
Open
flichtenheld wants to merge 1 commit intopuppetlabs:mainfrom
Open
apache::params: Use correct PHP version on Ubuntu 24.04#2575flichtenheld wants to merge 1 commit intopuppetlabs:mainfrom
flichtenheld wants to merge 1 commit intopuppetlabs:mainfrom
Conversation
flichtenheld
requested review from
a team,
bastelfreak,
ekohl and
smortex
as code owners
|
|
ekohl
requested changes
Oct 23, 2024
Collaborator
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
https://packages.ubuntu.com/noble/php confirms it's 8.3, but please fix the comment to match :)
manifests/params.pp
Outdated
| '12' => '8.2', # Debian Bookworm | ||
| '20.04' => '7.4', # Ubuntu Foccal Fossal | ||
| '22.04' => '8.1', # Ubuntu Jammy | ||
| '24.04' => '8.3', # Ubuntu Jammy |
Collaborator
There was a problem hiding this comment.
Suggested change
| '24.04' => '8.3', # Ubuntu Jammy | |
| '24.04' => '8.3', # Ubuntu Noble |
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
flichtenheld
force-pushed
the
php-ubuntu-noble
branch
from
d735f23 to
8664027
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update PHP version list for Ubuntu 24.04 (noble)
Additional Context
Straightforward.
Related Issues (if any)
Checklist
puppet apply)