Add a new CI job with Rust 1.83 and AWS-LC#14541
Conversation
| echo "RUSTFLAGS=-Clink-arg=-Wl,-rpath=${OSSL_PATH}/lib -Clink-arg=-Wl,-rpath=${OSSL_PATH}/lib64" >> $GITHUB_ENV | ||
| if: matrix.PYTHON.OPENSSL | ||
| - run: cargo install bindgen-cli | ||
| - run: rustup run stable cargo install bindgen-cli |
There was a problem hiding this comment.
Using cargo install directly here yields to a problem because the version is too old for bindgen-cli when using Rust 1.83
(proof)
| # potential future MSRV. | ||
| # noclippy due to: https://github.com/PyO3/pyo3/issues/5768 | ||
| - {VERSION: "3.14", NOXSESSION: "rust-noclippy,tests", RUST: "1.83.0"} | ||
| - {VERSION: "3.14", NOXSESSION: "rust-noclippy,tests", RUST: "1.83.0", OPENSSL: {TYPE: "aws-lc", VERSION: "v1.71.0"}} |
There was a problem hiding this comment.
Need to make sure the aws-lc bumper script will properly update this. (Set it to some old version and run:
python3 .github/bin/bump_dependency.py \
--name "AWS-LC" \
--repo-url "https://github.com/aws/aws-lc" \
--branch "main" \
--file-path ".github/workflows/ci.yml" \
--current-version-pattern 'TYPE: "aws-lc", VERSION: "(v[0-9\.]*)"' \
--update-pattern 'TYPE: "aws-lc", VERSION: "{new_version}"' \
--comment-pattern 'Latest tag of AWS-LC main branch, as of .*?\.' \
--tag \
--tag-pattern 'v[0-9\.]*'
There was a problem hiding this comment.
The script uses re.search that matches only the first occurrence (the one at line 46), but updates both because it uses re.sub which replaces all occurrences.
The script will update both if the first occurrence needs to be updated. If the initial version of the file is in sync, it would be automatically handled.
So I would say the support is accidental - I can update the script to be more explicit.
New PR, or since it's going to be a ~20 lines change, that could fit into this one?
Part of #14404, as we had coverage issues for AWS-LC gated methods.