Closed
Conversation
Contributor
Author
|
Please add skip news label, thanks! |
Member
|
Please first create an issue to discuss whether this is an acceptable change or not before creating a PR. I'm closing it because you need to follow our contribution guidelines. |
Member
Any change visible to the end-user must have a NEWS entry. In addition, PRs fixing bugs or adding features should usually include tests. |
Contributor
Author
|
Thanks for the information! I'll read the docs now at first, sorry for my mistake! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Not tested, just looking from the code, this should be necessary for some windows cases, but please review, thanks!)