Merged
Conversation
rosa
force-pushed
the
fix-puma-plugin-nil-pid
branch
from
1732b8e to
43e9a68
Compare
This was referenced Feb 18, 2026
Closed
When fork fails silently in restricted container environments, `solid_queue_pid` remains `nil`. On shutdown, Puma fires the stopped event and `stop_solid_queue_fork` is called, where `Process.waitpid(nil)` raises `TypeError`. Add an early return when `solid_queue_pid` is nil, and remove the now-redundant conditional on `Process.kill`. Related to #628 and #617 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rosa
force-pushed
the
fix-puma-plugin-nil-pid
branch
from
43e9a68 to
ea00232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
forkfails silently in restricted container environments,solid_queue_pidremainsnil. On shutdown, Puma fires the stopped event, andstop_solid_queue_forkis called, whereProcess.waitpid(nil)raisesTypeError.Add an early return when
solid_queue_pidisnil, and remove the now-redundant conditional onProcess.kill.Related to #628 and #617