Skip to content

Guard against nil pid in Puma plugin stop #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosa merged 1 commit into from
Feb 18, 2026
Merged

Guard against nil pid in Puma plugin stop #715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/puma/plugin/solid_queue.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,11 @@ def start_solid_queue(**options)
end

def stop_solid_queue_fork
return unless solid_queue_pid

Process.waitpid(solid_queue_pid, Process::WNOHANG)
log "Stopping Solid Queue..."
Process.kill(:INT, solid_queue_pid) if solid_queue_pid
Process.kill(:INT, solid_queue_pid)
Process.wait(solid_queue_pid)
rescue Errno::ECHILD, Errno::ESRCH
end
Expand Down
Loading