Restrict telemetry markers to error/critical paths only#125
Draft
Copilot wants to merge 2 commits intofeature/RDKEMW-16028from
Draft
Restrict telemetry markers to error/critical paths only#125Copilot wants to merge 2 commits intofeature/RDKEMW-16028from
Copilot wants to merge 2 commits intofeature/RDKEMW-16028from
Conversation
Agent-Logs-Url: https://github.com/rdkcentral/middleware-player-interface/sessions/fd2e29b3-4a81-42cd-bd05-3eda1680630b Co-authored-by: dp0000 <53818367+dp0000@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update telemetry markers to only emit on critical issues and errors
Restrict telemetry markers to error/critical paths only
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In production, the Ethan logger only emits
ETHAN_LOG_MILESTONEandETHAN_LOG_FATALentries. SincemLOGLEVEL_INFO,mLOGLEVEL_WARN, andmLOGLEVEL_MILwere all mapped toETHAN_LOG_MILESTONE, every routine success event (e.g. "Found source for video", "Create pipeline", "Gstreamer subs enabled") was generating a telemetry marker in production.Changes
playerLogManager/PlayerLogManager.cpp— Remapped MW log levels to Ethan log levels so onlymLOGLEVEL_ERRORproduces a telemetry-visible entry:ETHAN_LOG_INFOandETHAN_LOG_WARNINGare below the production filter threshold, so they are suppressed at runtime without requiring any changes to individualMW_LOG_MIL/MW_LOG_WARNcall sites.Original prompt
This pull request was created from Copilot chat.