Skip to content

Restrict telemetry markers to error/critical paths only #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: feature/RDKEMW-16028
Choose a base branch
from
+16 −5
Draft

Restrict telemetry markers to error/critical paths only #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
434e17e
Initial plan
Copilot Apr 3, 2026
f5e7063
Fix telemetry markers to only emit on critical errors, not normal events
Copilot Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions playerLogManager/PlayerLogManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,23 +138,34 @@ void logprintf(MW_LogLevel logLevelIndex, const char* func, int line, const char
{ // remap MW log levels to Ethan log levels
int ethanLogLevel;
// Important: in production builds, Ethan logger filters out everything
// except ETHAN_LOG_MILESTONE and ETHAN_LOG_FATAL
// except ETHAN_LOG_MILESTONE and ETHAN_LOG_FATAL.
// Only errors and critical failures should emit telemetry markers;
// normal/success events should not generate telemetry.
switch (logLevelIndex)
{
case mLOGLEVEL_TRACE:
case mLOGLEVEL_DEBUG:
ethanLogLevel = ETHAN_LOG_DEBUG;
break;

case mLOGLEVEL_ERROR:
ethanLogLevel = ETHAN_LOG_FATAL;
case mLOGLEVEL_INFO:
ethanLogLevel = ETHAN_LOG_INFO;
break;

case mLOGLEVEL_INFO: // note: we rely on eLOGLEVEL_INFO at tune time for triage
case mLOGLEVEL_WARN:
ethanLogLevel = ETHAN_LOG_WARNING;
break;

case mLOGLEVEL_MIL:
ethanLogLevel = ETHAN_LOG_WARNING;
break;

case mLOGLEVEL_ERROR:
ethanLogLevel = ETHAN_LOG_FATAL;
break;

default:
ethanLogLevel = ETHAN_LOG_MILESTONE;
ethanLogLevel = ETHAN_LOG_WARNING;
break;
}
vethanlog(ethanLogLevel,NULL,NULL,-1,format_ptr, args);
Expand Down