Skip to content

Remove duplicate pkg_check_modules definitions in PluginsTests #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: feature/RDKEMW-11934
Choose a base branch
from
Draft

Remove duplicate pkg_check_modules definitions in PluginsTests #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0223b8a
Initial plan
Copilot Jan 22, 2026
e210f7f
Remove duplicate pkg_check_modules definitions for GStreamer
Copilot Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions test/utests/tests/PluginsTests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ include(GoogleTest)

pkg_check_modules(UUID REQUIRED uuid)
pkg_check_modules(GOBJECT REQUIRED gobject-2.0)
pkg_check_modules(GSTREAMER REQUIRED gstreamer-1.0)
pkg_check_modules(GSTREAMERAPP REQUIRED gstreamer-app-1.0)
pkg_check_modules(GSTREAMERBASE REQUIRED gstreamer-base-1.0)
pkg_check_modules(GST REQUIRED IMPORTED_TARGET
gstreamer-1.0
gstreamer-base-1.0
Expand Down Expand Up @@ -53,16 +50,14 @@ include_directories(${GLIB_INCLUDE_DIRS})
include_directories(${DRM_ROOT}/ocdm)
include_directories(${UTESTS_ROOT}/mocks)
include_directories(${UTESTS_ROOT}/drm/mocks)
include_directories(${GSTREAMER_INCLUDE_DIRS})
include_directories(${GSTREAMERAPP_INCLUDE_DIRS})
include_directories(${GSTREAMERBASE_INCLUDE_DIRS})
include_directories(${GST_INCLUDE_DIRS})
include_directories(${LIBCJSON_INCLUDE_DIRS})
include_directories(${UUID_INCLUDE_DIRS})

if (JSC_INCDIR)
include_directories(${JSC_INCDIR})
endif()
message(GSTREAMER_INCLUDE_DIRS=${GSTREAMER_INCLUDE_DIRS})
message(GST_INCLUDE_DIRS=${GST_INCLUDE_DIRS})

set(FAKE_SOURCES ${UTESTS_ROOT}/fakes/FakeGStreamer.cpp)

Expand Down Expand Up @@ -145,9 +140,7 @@ else()
${GMOCK_LINK_LIBRARIES}
${GTEST_LINK_LIBRARIES}
${GOBJECT_LINK_LIBRARIES}
${GSTREAMERAPP_LINK_LIBRARIES}
${GSTREAMERBASE_LINK_LIBRARIES}
${GSTREAMER_LINK_LIBRARIES} # This should resolve to -lgstreamer-1.0 etc.
PkgConfig::GST
)
endif()

Expand Down