Skip to content

Remove duplicate pkg_check_modules definitions in PluginsTests#67

Draft
Copilot wants to merge 2 commits intofeature/RDKEMW-11934from
copilot/sub-pr-64
Draft

Remove duplicate pkg_check_modules definitions in PluginsTests#67
Copilot wants to merge 2 commits intofeature/RDKEMW-11934from
copilot/sub-pr-64

Conversation

Copy link
Copy Markdown

Copilot AI commented Jan 22, 2026

Addresses review feedback on duplicate GStreamer package checks in test/utests/tests/PluginsTests/CMakeLists.txt.

Changes

  • Removed duplicate pkg_check_modules calls: Individual GSTREAMER, GSTREAMERAPP, and GSTREAMERBASE definitions removed; retained consolidated GST with IMPORTED_TARGET
  • Consolidated variables: All references updated to use GST_INCLUDE_DIRS and PkgConfig::GST instead of individual package variables
  • Aligned with codebase pattern: Matches approach used in GstPlayer/CMakeLists.txt

Before:

pkg_check_modules(GSTREAMER REQUIRED gstreamer-1.0)
pkg_check_modules(GSTREAMERAPP REQUIRED gstreamer-app-1.0)
pkg_check_modules(GSTREAMERBASE REQUIRED gstreamer-base-1.0)
pkg_check_modules(GST REQUIRED IMPORTED_TARGET
    gstreamer-1.0
    gstreamer-base-1.0
    gstreamer-app-1.0
)
# ...
include_directories(${GSTREAMER_INCLUDE_DIRS})
include_directories(${GSTREAMERAPP_INCLUDE_DIRS})
include_directories(${GSTREAMERBASE_INCLUDE_DIRS})
# ...
target_link_libraries(... ${GSTREAMER_LINK_LIBRARIES} ${GSTREAMERAPP_LINK_LIBRARIES} ...)

After:

pkg_check_modules(GST REQUIRED IMPORTED_TARGET
    gstreamer-1.0
    gstreamer-base-1.0
    gstreamer-app-1.0
)
# ...
include_directories(${GST_INCLUDE_DIRS})
# ...
target_link_libraries(... PkgConfig::GST)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: rekhap2kandhavelan <217911244+rekhap2kandhavelan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix build failure in MAC based on feedback Remove duplicate pkg_check_modules definitions in PluginsTests Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants