-
Notifications
You must be signed in to change notification settings - Fork 8
Improve homepage semantic HTML and accessibility for AI crawlers #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,75 +1,91 @@ | ||
| <div id="preamble"> | ||
| <main class="home-content"> | ||
| <section id="preamble" aria-labelledby="home-overview"> | ||
| <div class="sectionbody"> | ||
| <div class="paragraph home-intro"> | ||
| {{#with page.attributes.home-overview-title}} | ||
| <h2 id="home-overview">{{{this}}}</h2> | ||
| {{else}} | ||
| <h2 id="home-overview">Overview</h2> | ||
| {{/with}} | ||
| <p>{{{page.attributes.home-intro}}} {{#with page.attributes.home-intro-learn-more}}<a href="{{{relativize (resolve-resource this)}}}">Learn more</a>{{/with}} | ||
| </p> | ||
| {{#if page.attributes.home-ai-summary}} | ||
| <p class="home-ai-summary">{{{page.attributes.home-ai-summary}}}</p> | ||
| {{/if}} | ||
| {{#if page.attributes.home-image}} | ||
| <img style="max-height: 150px;min-height: 120px;" src="../_images/{{page.attributes.home-image}}" alt="{{{page.title}}}" loading="lazy"/> | ||
| <img style="max-height: 150px;min-height: 120px;" src="../_images/{{page.attributes.home-image}}" alt="{{#if page.attributes.home-image-alt}}{{page.attributes.home-image-alt}}{{else}}{{page.title}}{{/if}}" loading="lazy"/> | ||
| {{/if}} | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <section class="sect1 features"> | ||
| </section> | ||
| <section class="sect1 features" aria-labelledby="home-primary-title"> | ||
| {{#with page.attributes.home-primary-row-title}} | ||
| <h2 id="{{{this}}}">{{{this}}}<a class="anchor" href="#{{{this}}}"></a></h2> | ||
| <h2 id="home-primary-title">{{{this}}}<a class="anchor" href="#home-primary-title"></a></h2> | ||
| {{else}} | ||
| <h2 id="home-primary-title" class="visually-hidden">Featured content</h2> | ||
| {{/with}} | ||
JakeSCahill marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <div class='sectionbody container'> | ||
| <div class="sectionbody container"> | ||
| <div class="grid-primary boxes"> | ||
| {{#each page.attributes.home-primary-row}} | ||
| <a href="{{{relativize (resolve-resource url)}}}" class="feature-link"> | ||
| <div class="feature-box"> | ||
| <article class="feature-box"> | ||
| <a href="{{{relativize (resolve-resource url)}}}" class="feature-link"> | ||
| <div class="feature-text"> | ||
| <h3 id="{{{title}}}" class="feature-title">{{{title}}}</h2> | ||
| <h3 class="feature-title">{{{title}}}</h3> | ||
| {{#if description}} | ||
| <p class="feature-description">{{{description}}}</p> | ||
| {{/if}} | ||
| {{#if link-text}} | ||
| <p class="feature-link-text get-started">{{{link-text}}}</p> | ||
| {{/if}} | ||
| </div> | ||
| </div> | ||
| </a> | ||
| </a> | ||
| </article> | ||
| {{/each}} | ||
| </div> | ||
| </div> | ||
| </section> | ||
| <section class="sect1 features"> | ||
| <section class="sect1 features" aria-labelledby="home-secondary-title"> | ||
| {{#with page.attributes.home-secondary-row-title}} | ||
| <h2 id="{{{this}}}">{{{this}}}<a class="anchor" href="#{{{this}}}"></a></h2> | ||
| <h2 id="home-secondary-title">{{{this}}}<a class="anchor" href="#home-secondary-title"></a></h2> | ||
| {{else}} | ||
| <h2 id="home-secondary-title" class="visually-hidden">More resources</h2> | ||
| {{/with}} | ||
| <div class='sectionbody container'> | ||
| <div class="sectionbody container"> | ||
| <div class="grid-secondary boxes"> | ||
| {{#each page.attributes.home-secondary-row}} | ||
| <a href="{{{relativize (resolve-resource url)}}}" class="feature-link"> | ||
| <div class="feature-box"> | ||
| <article class="feature-box"> | ||
| <a href="{{{relativize (resolve-resource url)}}}" class="feature-link"> | ||
| <div class="feature-text"> | ||
| <h3 id="{{{title}}}" class="feature-title">{{{title}}}</h2> | ||
| <h3 class="feature-title">{{{title}}}</h3> | ||
| {{#if description}} | ||
| <p class="feature-description">{{{description}}}</p> | ||
| {{/if}} | ||
| {{#if link-text}} | ||
| <p class="feature-link-text">{{{link-text}}}</p> | ||
| {{/if}} | ||
| </div> | ||
| </div> | ||
| </a> | ||
| </a> | ||
| </article> | ||
| {{/each}} | ||
| </div> | ||
| </div> | ||
| </section> | ||
| <section class="sect1 features"> | ||
| <section class="sect1 features" aria-labelledby="home-tertiary-title"> | ||
| {{#with page.attributes.home-tertiary-row-title}} | ||
| <h2 id="{{{this}}}">{{{this}}}<a class="anchor" href="#{{{this}}}"></a></h2> | ||
| <h2 id="home-tertiary-title">{{{this}}}<a class="anchor" href="#home-tertiary-title"></a></h2> | ||
| {{else}} | ||
| <h2 id="home-tertiary-title" class="visually-hidden">Additional links</h2> | ||
| {{/with}} | ||
| <div class='sectionbody container'> | ||
| <div> | ||
| <div class="sectionbody container"> | ||
| <nav aria-label="Additional resources"> | ||
| <ul class="grid-tertiary"> | ||
| {{#each page.attributes.home-tertiary-row}} | ||
| <li> | ||
| <a href="{{{relativize (resolve-resource url)}}}">{{{title}}}</a> | ||
| <a href="{{{relativize (resolve-resource url)}}}">{{{title}}}</a> | ||
| </li> | ||
| {{/each}} | ||
| </ul> | ||
| </div> | ||
| </nav> | ||
| </div> | ||
| </section> | ||
| </main> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.