-
Notifications
You must be signed in to change notification settings - Fork 6
refactor(client): use named imports for hot emitter and log #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Timeless0911, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing code consistency and maintainability within the client-side codebase. It achieves this by standardizing the import mechanisms for specific modules, transitioning from default imports to named imports. This change aligns with modern JavaScript module practices, improving clarity and potentially aiding static analysis. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the client code to use named imports for @rspack/core/hot/emitter.js and @rspack/core/hot/log.js. This is a good change that improves the explicitness of the imports. The implementation is correct and I have no further comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Refactors the dev-server runtime client to import the Rspack HMR emitter and logger via named exports instead of default exports.
Changes:
- Switched
@rspack/core/hot/emitter.jsimport to a named import (emitteraliased tohotEmitter). - Switched
@rspack/core/hot/log.jsimport to a named import (logaliased towebpackHotLog).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44ddec3ad6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import { emitter as hotEmitter } from '@rspack/core/hot/emitter.js'; | ||
| /* Rspack dev server runtime client */ | ||
| // @ts-expect-error: No type definitions available for '@rspack/core/hot/log.js' | ||
| import webpackHotLog from '@rspack/core/hot/log.js'; | ||
| import { log as webpackHotLog } from '@rspack/core/hot/log.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guard named HMR imports behind a Rspack v2 peer range
These new named imports make the runtime client depend on the v2 export shape, but this commit does not restrict consumers to @rspack/core v2 (the package still allows older peer versions), so projects still on v1 can install this release and then fail at runtime when HMR paths use hotEmitter/webpackHotLog. Please either keep backward-compatible imports or tighten the peer compatibility contract in the same change.
Useful? React with 👍 / 👎.
NOTICE: MERGE IT AFTER BUMPING RSPACK V2
Description
This PR refactors the client code to use named imports for
@rspack/core/hot/emitter.jsand@rspack/core/hot/log.jsinstead of default imports.Related Issue
N/A
Checklist