Skip to content

refactor(client): use named imports for hot emitter and log #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Timeless0911 wants to merge 4 commits into
base: main
Choose a base branch
from
+75 −125
Open

refactor(client): use named imports for hot emitter and log #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd56be0
refactor(client): use named imports for hot emitter and log
Timeless0911 Feb 4, 2026
c78b3ac
fix
chenjiahan Feb 11, 2026
44ddec3
fix
chenjiahan Feb 11, 2026
5b1fc2e
fix
chenjiahan Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client-src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
*/

// @ts-expect-error: No type definitions available for '@rspack/core/hot/emitter.js'
import hotEmitter from '@rspack/core/hot/emitter.js';
import { emitter as hotEmitter } from '@rspack/core/hot/emitter.js';
/* Rspack dev server runtime client */
// @ts-expect-error: No type definitions available for '@rspack/core/hot/log.js'
import webpackHotLog from '@rspack/core/hot/log.js';
import { log as webpackHotLog } from '@rspack/core/hot/log.js';
Comment on lines +12 to +15
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard named HMR imports behind a Rspack v2 peer range

These new named imports make the runtime client depend on the v2 export shape, but this commit does not restrict consumers to @rspack/core v2 (the package still allows older peer versions), so projects still on v1 can install this release and then fail at runtime when HMR paths use hotEmitter/webpackHotLog. Please either keep backward-compatible imports or tighten the peer compatibility contract in the same change.

Useful? React with 👍 / 👎.

import { createOverlay, formatProblem } from './overlay.js';
import socket from './socket.js';
import { defineProgressElement, isProgressSupported } from './progress.js';
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"@biomejs/biome": "^1.8.3",
"@jest/reporters": "29.7.0",
"@jest/test-sequencer": "^29.7.0",
"@rspack/core": "1.7.1",
"@rspack/core": "2.0.0-beta.2",
"@rspack/plugin-react-refresh": "1.0.0",
"@types/express": "5.0.6",
"@types/jest": "29.5.12",
Expand Down Expand Up @@ -98,7 +98,7 @@
"supertest": "^6.1.3",
"tcp-port-used": "^1.0.2",
"ts-jest": "29.1.2",
"typescript": "5.0.2",
"typescript": "^5.9.3",
"wait-for-expect": "^3.0.2",
"webpack": "^5.94.0",
"webpack-merge": "^6.0.1",
Expand Down
Loading
Loading