Add specs for IO.select with other Float special values as timeout #1338
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
approved these changes
Jan 30, 2026
eregon
reviewed
Jan 30, 2026
core/io/select_spec.rb
Outdated
|
|
||
| ruby_version_is "4.0" do | ||
| it "raises an ArgumentError when passed negative infinity as timeout" do | ||
| -> { IO.select(nil, nil, nil, -Float::INFINITY)}.should raise_error(ArgumentError) |
Member
There was a problem hiding this comment.
If the exception messages are meaningful it seems worth specifying it them here.
It'll also convenient when implementing those semantics, vs having to check what message CRuby uses.
Member
Author
There was a problem hiding this comment.
This one is the same as the negative finite value. For consistency, I added a check for that case as well.
Member
|
Feel free to merge yourself, I won't merge now in case you want to change something re #1338 (comment) |
Since `(-Float::INFINITY).infinite?` returns a truthy value, this should probably be covered.
herwinw
force-pushed
the
io_select_negative_infinity_timeout
branch
from
c2df414 to
c5ad958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Float::INIFINITYis now supported, but-Float::INFINITYandFloat::NANare other special values.The negative infinity value overlaps with the regular negative values, but it does cover the scenario where a Ruby implementation would just check for
float.infinity?in a boolean context for no timeout.