Skip to content

Add specs for IO.select with other Float special values as timeout #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eregon merged 3 commits into from
Feb 4, 2026
Merged

Add specs for IO.select with other Float special values as timeout #1338

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c047e96
Validate error message for IO.select with negative timeout
herwinw Feb 2, 2026
1fbb6bc
Add spec for IO.select with -INFINITY as timeout
herwinw Jan 28, 2026
c5ad958
Add spec for IO.select with NaN as timeout
herwinw Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion core/io/select_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,17 @@
end

it "raises an ArgumentError when passed a negative timeout" do
-> { IO.select(nil, nil, nil, -5)}.should raise_error(ArgumentError)
-> { IO.select(nil, nil, nil, -5)}.should raise_error(ArgumentError, "time interval must not be negative")
end

ruby_version_is "4.0" do
it "raises an ArgumentError when passed negative infinity as timeout" do
-> { IO.select(nil, nil, nil, -Float::INFINITY)}.should raise_error(ArgumentError, "time interval must not be negative")
end
end

it "raises an RangeError when passed NaN as timeout" do
-> { IO.select(nil, nil, nil, Float::NAN)}.should raise_error(RangeError, "NaN out of Time range")
end

describe "returns the available descriptors when the file descriptor" do
Expand Down