Constrain hero carousel height and stretch to full width on story share portal#913
Merged
maebeale merged 6 commits intostory-share-portalfrom Feb 10, 2026
Merged
Conversation
Merged
318da0d to
18939b5
Compare
Copilot
AI
changed the title
[WIP] Work in progress for story share portal
Constrain hero carousel height on story share portal
Feb 10, 2026
Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
c0cf17d to
e7b53e3
Compare
Collaborator
|
@copilot stretch the hero image horizontally to fit the width on share_portal index |
Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
Contributor
Author
I've updated the hero image to stretch horizontally to fill the full width of the container. Changes in commit 858e3b9:
|
Copilot
AI
changed the title
Constrain hero carousel height on story share portal
Constrain hero carousel height and stretch to full width on story share portal
Feb 10, 2026
maebeale
added a commit
that referenced
this pull request
Feb 11, 2026
…re portal (#913) * Initial plan * Limit hero image height to prevent vertical growth Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Allow extra classes to be sent in * Don't hard-code the size * Stretch hero image to full width horizontally Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Hard-code nav item colors --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> Co-authored-by: maebeale <maebeale@users.noreply.github.com>
maebeale
added a commit
that referenced
this pull request
Feb 11, 2026
…re portal (#913) * Initial plan * Limit hero image height to prevent vertical growth Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Allow extra classes to be sent in * Don't hard-code the size * Stretch hero image to full width horizontally Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Hard-code nav item colors --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> Co-authored-by: maebeale <maebeale@users.noreply.github.com>
maebeale
added a commit
that referenced
this pull request
Feb 12, 2026
…re portal (#913) * Initial plan * Limit hero image height to prevent vertical growth Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Allow extra classes to be sent in * Don't hard-code the size * Stretch hero image to full width horizontally Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Hard-code nav item colors --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> Co-authored-by: maebeale <maebeale@users.noreply.github.com>
maebeale
added a commit
that referenced
this pull request
Feb 12, 2026
* WIP: story share portal * WIP: show page for story * Isolate Story Share Portal with dedicated purple-themed layout (#903) * Initial plan * Redesign share_portal page with Tailwind CSS to match design Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Add full-width layout support for share_portal page Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Address code review feedback: add accessibility labels and use dynamic story links Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Create separate layout for story share portal with purple navigation Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Address code review feedback: remove redundant nav wrapper and duplicate link Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Redesign Story Share Portal to match visual specifications (#904) * Initial plan * Add Telefon font, redesign navbar with 3 rows, update sector styling and overlays Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Refine font declarations and remove unused CSS variables Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Fix Tailwind class interpolation and improve scroll performance Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Use actual story sectors for category badges in What Others Are Reading Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Add new logo image and merge conflict * Redesign Story Share Portal to match visual specifications (#905) * Initial plan * Update story share portal navigation and layout to match design Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Force first 5 stories for stories_by_focus for now * Refine Story Share Portal layout and visual hierarchy (#911) * Initial plan * Update Story Share Portal layout per feedback Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Visual tweaks * WIP: messing w hero height * Fixes * Refine What Others Are Reading section colors and alignment (#912) * Initial plan * Update What Others Are Reading section colors and alignment Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Constrain hero carousel height and stretch to full width on story share portal (#913) * Initial plan * Limit hero image height to prevent vertical growth Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Allow extra classes to be sent in * Don't hard-code the size * Stretch hero image to full width horizontally Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Hard-code nav item colors --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> Co-authored-by: maebeale <maebeale@users.noreply.github.com> * Add individual story view with share portal layout and navigation (#915) * Initial plan * Add show_share_portal page with matching layout and navigation Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Improve popular stories query and sector fallback Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Fix test --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Hero section was using a flexible aspect ratio that caused vertical expansion with large images. Fixed height prevents layout instability and matches design spec. Additionally, the hero image now stretches horizontally to fill the full container width.
How did you approach the change?
aspect-[16/6]toh-96 max-h-96(384px fixed height)object-coverto hero variant so images crop/scale to fit container!w-fullto ensure image stretches horizontally to fill the container widthAnything else to add?
Image now:
object-coverto properly crop/scale while maintaining aspect ratio💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.